Xen project Mailing List

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

To: Jan Beulich <jbeulich@xxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>

From: Jason Andryuk <jason.andryuk@xxxxxxx>

Date: Wed, 24 Jul 2024 09:18:16 -0400

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=opazuiMa3MEJlGARPBRbOaInCWrVby0T5oXoADeSrJ4=; b=RWm5jGnpmqChDCiUbAPASrE9RMM3k75RdlAVJ4QXStUIK3z6Ba5yL6g5xjzYOdHee0YIX9cDhJxyAiwZp4LjeExV3p09UmkD6wRRzNuMg2VF4NE4ekOBWfLS9ec/RsLnLpCfYrGIeUkzd1wvbu4z9Yyg1og0xNcyDGWKENPz3tvlP3pLSTFQ0BaKikjB5uBl8JMM+SUCJSNcNk+JNPdnHlYSGOSfXpE7wmfHnA30XccJ1xZq+2t+P15kAYG2uGvS4UcrxQgznYEZJ+3LG/ZC2Ib3QKKevKB6DljV91ekr9rGkIa9YTVdFTIeyTYzqOUcGqua1s1MNJvuTsb4WwGC4w==

Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d/eBxhTshMpT5Kq6VsOqAjBc+/IC+6AbqM+u2BJzxY9K3Nz59GwyGzwh2zp0TxRKl5c9dYDmBEqvA6TZNK5SwF6sBMxOLU+rSiv9hXEI8RmWWb4wbDWPbvKJmu0P9sEHlLKlw69yFSteCVKCB7bcB3pxJXgBBLvnakPD9nlwmdkivilQzZmRSexHj87AElEXvwyfHdo8VhufcAEZOmkuUpV6+FqJqMos5wnUX8fok2q/NVyiDaSyn5LxVNjO5l20Xe0S0f4nWTkA7FPy5ZQUYVpGiigNslrB2NTwtZd0gLkkxOaiE7CBzfQdcCy3OEhXgRsLUG/5HcAVTNJS95+srw==

Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>

Delivery-date: Wed, 24 Jul 2024 13:36:01 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2024-07-24 08:41, Jan Beulich wrote:

On 23.07.2024 17:04, Anthony PERARD wrote:

On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote:

"$dev" needs to be set correctly for backendtype=phy as well as
backendtype=tap.  Move the setting into the conditional, so it can be
handled properly for each.

(dev could be captured during tap-ctl allocate for blktap module, but it
would not be set properly for the find_device case.  The backendtype=tap
case would need to be handled regardless.)

Fixes: 6fcdc84927 ("hotplug: Restore block-tap phy compatibility")


Do you mean f16ac12bd418 ("hotplug: Restore block-tap phy compatibility") ?


Which, when replacing it, made noticeable that the above and ...

Fixes: 76a484193d ("hotplug: Update block-tap")


... this hash also were too short. Please make sure you use 12 digits, as
indicated by docs/process/sending-patches.pandoc.

Sorry about that. I'll make sure to use 12 in the future. Thanks for

catching and fixing up.

Regards, Jason

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.