[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] automation: add linker symbol name script
- To: "Lira, Victor M" <VictorM.Lira@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Wed, 24 Jul 2024 16:20:47 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qt8PFUHR0NGaLcUJDI79oVJqQ29PrPLiklg/4GNIWLQ=; b=SKW1TymZthpa06nbiTvXYjPgbI0LFVUW17glAKsk2nf2HorkgA7ErcK2r7mrJkzBQyxbLFGhtqPzw2znhDnMVAshDLddQOE0Era8oMfUnBw6cSQY5RJM4P2Qms5hLwhr6fQrfKP3Va5k/voeCh1rO5aGRd8Z+eZ5xbPxTdh8KaS/W9721AA+/p0b1U0F7YaqCQY8NEY55ska9dP8PWRFLvuZN0QdM7ttEOGfo2u/38/ziCua9dGjJOg7PlGBtWR63s/GUHd75y4h8POMoRjJwVbLGon2lGLHmvW9IXv2K0jlhlXd7g5Ma82iM3JyeodFifgbFyqindNI6Q+455u/Bg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fdex6aqGwqsVMLmIGMA080hxDmM7SmLRc3wqAbrGi9znHcFxEB9VDe3lYjaDdIAfjhqFpzu59r37rFgBqXwF80mdBl6mtrAj6bn4wEesUuC9Ib1wecNtYfadV+YLmScQ8hlqEDDvkPe0IV5hm6zb13SbsjbfKiH3/Eni1W4TPiXo49w0kFktwQhpsrTx1X+uLuO5qb5sujI30xTKSpWIvz7BYcqIcLAxrVPg31goU/7INXhovC4ATWToNu2fZ8IDZYXaGi/hWsA3C1ylGIe+ERjYmdPYO3q2H9GnH3nYJocfjy3Tlf5npctedJ4RRX3KXBkTBmQ/klAfvh+uD0SR+A==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, <roberto.bagnara@xxxxxxxxxxx>, <consulting@xxxxxxxxxxx>, <simone.ballarin@xxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 24 Jul 2024 20:24:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2024-07-24 13:48, Lira, Victor M wrote:
On 7/24/2024 12:44 AM, Jan Beulich wrote:
Nit: In names of new files we prefer - over _.
+script_name=`basename "$0"`
I have fixed the above comments in v2.
+#!/bin/bash
Can we rely on bash to be there and at that location? As you using any
bash-isms in the script which cannot be avoided?
Are the automation scripts required to be portable? Can you please point
me to a resource where I can learn how to make the script portable?
Hi Victor,
You might want to check out `checkbashisms`:
$ checkbashisms
Usage: checkbashisms [-n] [-f] [-x] [-e] [-l] script ...
or: checkbashisms --help
or: checkbashisms --version
This script performs basic checks for the presence of bashisms
in /bin/sh scripts and the lack of bashisms in /bin/bash ones.
Since your script has '#!/bin/bash', you'd run it with -f to force the
bashism checks (or change to /bin/sh first).
Regards,
Jason
|
