Re: [RFC PATCH v2] automation: add linker symbol name script

[Jan Beulich <jbeulich@xxxxxxxx>]

On 24.07.2024 19:52, victorm.lira@xxxxxxx wrote:
> From: Victor Lira <victorm.lira@xxxxxxx>
> 
> Signed-off-by: Victor Lira <victorm.lira@xxxxxxx>
> Requested-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Note: Tags in chronological order, please. Stefano isn't likely to have 
requested
that after you signed off on the change. As an aside, aiui Stefano requested 
this
in response to me having requested it on the call earlier this week.

> --- /dev/null
> +++ b/automation/eclair_analysis/linker-symbols.sh
> @@ -0,0 +1,34 @@
> +# Stop immediately if any executed command has exit status different from 0.
> +set -e
> +
> +# Extract linker symbol names (except those starting with ".") from 
> assignments.
> +
> +script_name=$(basename "$0")
> +script_dir="$(
> +  cd "$(dirname "$0")"
> +  echo "${PWD}"
> +)"
> +src_dir="${script_dir}/../.."
> +
> +usage() {
> +  echo "Usage: ${script_name} <arm|x86>"
> +}
> +
> +if [ $# -ne 1 ]; then
> +  usage
> +  exit 1
> +fi
> +
> +if [ "$1" != "arm" ] && [ "$1" != "x86" ]; then
> +    usage
> +    exit 1
> +fi

This isn't really needed when you ...

> +filepath="${src_dir}/xen/arch/${1}/xen.lds"
> +
> +if [ ! -f "$filepath" ]; then
> +    echo "Must be run after build."
> +    exit 2
> +fi

... check existence first here. Perhaps worth mentioning $1 in the error
message, as having done just some build may not be sufficient.

Plus, for all error messages: The better want re-directing via >&2.

Jan