Re: [PATCH 2/3] xen: silence maybe-unitialized warning

[Jürgen Groß <jgross@xxxxxxxx>]

On 29.07.24 21:01, Stewart Hildebrand wrote:
> On 7/29/24 11:03, Jürgen Groß wrote:
> > On 29.07.24 16:24, Stewart Hildebrand wrote:
> > > When building with gcc with -finstrument-functions, optimization level
> > > -O1, CONFIG_HYPFS=y and # CONFIG_HAS_SCHED_GRANULARITY is not set, the
> > > the following build warning (error) is encountered:
> > >
> > > common/sched/cpupool.c: In function ‘cpupool_gran_write’:
> > > common/sched/cpupool.c:1220:26: error: ‘gran’ may be used uninitialized 
> > > [-Werror=maybe-uninitialized]
> > >    1220 |                      0 : cpupool_check_granularity(gran);
> > >         |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > common/sched/cpupool.c:1207:21: note: ‘gran’ declared here
> > >    1207 |     enum sched_gran gran;
> > >         |                     ^~~~
> > >
> > > This is a false positive. Silence the warning (error) by initializing
> > > the variable.
> > >
> > > Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
> > Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
> Thanks!
>
> It just occurred to me: should the subject prefix be xen/cpupool:
> instead of plain xen: ?
Probably, yes.


Juergen