Re: [PATCH] bunzip2: fix rare decompression failure

[Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>]

On Tue, Jul 30, 2024 at 10:25 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 30.07.2024 10:03, Ross Lagerwall wrote:
> > The decompression code parses a huffman tree and counts the number of
> > symbols for a given bit length.  In rare cases, there may be >= 256
> > symbols with a given bit length, causing the unsigned char to overflow.
> > This causes a decompression failure later when the code tries and fails to
> > find the bit length for a given symbol.
> >
> > Since the maximum number of symbols is 258, use unsigned short instead.
> >
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> A Fixes: tag and maybe an Origin: one would have been nice; the latter just
> "maybe" because the Linux patch is one of yours anyway.
>

Indeed, I decided against an origin tag since I wasn't backporting
someone else's change from Linux, just fixing the same thing in
multiple places.

I should have added a fixes tag. Here it is:

Fixes: ab77e81f6521 ("x86/dom0: support bzip2 and lzma compressed
bzImage payloads")

Thanks,
Ross