Re: [PATCH v3 4/9] xen/riscv: setup fixmap mapping

[oleksii.kurochko@xxxxxxxxx]

On Mon, 2024-07-29 at 15:35 +0200, Jan Beulich wrote:
> > +    }
> > +
> > +    BUG_ON(pte_is_valid(*pte));
> > +
> > +    tmp = paddr_to_pte(LINK_TO_LOAD((unsigned long)&xen_fixmap),
> > PTE_TABLE);
> 
> I'm a little puzzled by the use of LINK_TO_LOAD() (and LOAD_TO_LINK()
> a
> little further up) here. Don't you have functioning __pa() and
> __va()?
Can __pa() and __va() be used in this case?

According to comments for other architectures, these macros are used
for converting between Xen heap virtual addresses (VA) and machine
addresses (MA). I may have misunderstood what is meant by the Xen heap
in this context, but I'm not sure if xen_fixmap[] and page tables are
considered part of the Xen heap.

~ Oleksii