[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/4] xen: arm: Enclose access to EL2 MMU specific registers under CONFIG_MMU
- To: Michal Orzel <michal.orzel@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, sstabellini@xxxxxxxxxx, bertrand.marquis@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, julien@xxxxxxx
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Mon, 12 Aug 2024 18:13:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DKru4S+QNA4hEk1mp8ahGuyyOr4JCd++1MajJCNbRZ8=; b=y8N7FiS7B4e7uKePD8qyOaDHto7G+FMoGTKaR9RXxsq6LRPJ2Jy/Me6l6qgkLN0EAcdDLWEQXJazvbHConiuWqq+27rpfgjiJB5gags5IyRAADTCFGrXQCCjL7U9KTAjoqmwPIUW6A42zteDgZAatQl+p2p7aw9D8qz1kf9MSmjlBid83FFt7pCzVHjRGApHXmmm8bD0Ac80ELj38Pccykw07/VOKBIpIiosA+b3n2bUr0uBl+7k6P9lAITKJcZ/pd7YSKKD7u5SVwJmTOuuI2yn/kjAubMoWVGQ309nUYhaH/6yM+JctFVArep1wEHKLgGZstf7szy+igpWj5enGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fLkLoxFpnqNmjjqlKvABEe70Qs+viReO1xDv+2gKtKT0/UZVen5ykfxXSBJ/GKIaEu7BbBpIQCFZxYaxT4HMgZ5SeLbGzENWGBHfo+SDC/bP4+CN0KK96RPx8gyQqTZHgQOnLc7EPcWmCZGOaO/ycx1zAvzi9K/Yz3wrerxFmcK9zfCkoND67sT/Y6W6Qxde59Lldg3CRTV2xxYuMgMvm6xmfoIgOmJp1gCP0+RsyAHPmtAZjqq3QiuomNDsBtzbN3TacvqkP9efc7xngZYcJGqfxujN9FcOI0fj/AzLA5kP8QGptOl6z2UG7s9sEpUmhMp11qHLPnnhCnu6H5IKBA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 12 Aug 2024 17:14:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09/08/2024 13:15, Michal Orzel wrote:
Hi Ayan,
Hi Michal,
On 08/08/2024 14:09, Ayan Kumar Halder wrote:
All the EL2 MMU specific registers are enclosed within CONFIG_MMU.
Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
---
Changes from v1 :-
1. 'vttbr_el2' field is enclosed with ifdef.
2. No movement of code.
xen/arch/arm/traps.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index aac6c599f8..f51e1424cb 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -720,8 +720,10 @@ struct reg_ctxt {
uint32_t ifsr32_el2;
#endif
+#ifdef CONFIG_MMU
/* Hypervisor-side state */
uint64_t vttbr_el2;
Given that you protected the field here, why did you leave assignments in
show_registers()
and vcpu_show_registers() unguarded?
Makes sense. Sorry I forgot about that.
- Ayan
|
