[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Arm: correct FIXADDR_TOP
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Tue, 13 Aug 2024 13:57:27 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KmZoc6IWSHgbKkmrw1x+dETeDdHC6oQl8M2amGDWB1g=; b=iSkHpUkf6V66HKWQaRexd3sJddc7Nq1Nn1etHPtJv39KuwQEfDE/7CDm57bryKdRlzuh5ake74blBZgLJObzBbrprEB8pbpqaKfgWMMFCWQ/OGL19BMK4ARWT9W9XmiEC30UrFrW4qhRpPGM7W+zyhr4BnDm5cZYIV+AyCRttWYiUSWui53G1S6DRfE7dMPHuFzO+eWBOkCY8jAb7eSLlnLiDaUIhYVLQZcr06q1EIrfFikClqahi1WAw4YLDd1qnkRJMISKoOp4agW+1eefT/C02P6Cy6/f57DVGs8PZQwp1yIF6/OVzqhm/LH6Bfryv218RePxlBojnJzTKXr0Jg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jymJ+4Tyy5dIsAMswQlh7hFPvz4hQcWUGFR3sa+uQ69RcL+ucmkrc/zHx53ENjp3gWfUheyElN7reB4lL969870CegQpZiTQCVxh2PJtZc/5+h7Y3L54wCeJ9SGBB2sc6LlaLoLJlT54JDPNJzdK/1f9sbkTY+Y4umu15l+ICl50KpcX2vvso2tzfspyUCkyfAxGr5XFG36jCs+Qo7j7nrVSb7Yj0Pb2oPtXUYRmh7+pPT45DioZK51Jynu8YHGnmQ2IFW9sVdWjmaXtrdasGH0TEZd7XwcOM+SlWhIiwfANpmjGX3O5lasVlfjobe6QpWn/d5t7mmF9gLgCWQuTCQ==
- Cc: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Tue, 13 Aug 2024 11:57:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/08/2024 13:49, Jan Beulich wrote:
>
>
> While reviewing a RISC-V patch cloning the Arm code, I noticed an
> off-by-1 here: FIX_PMAP_{BEGIN,END} being an inclusive range and
> FIX_LAST being the same as FIX_PMAP_END, FIXADDR_TOP cannot derive from
> FIX_LAST alone, or else the BUG_ON() in virt_to_fix() would trigger if
> FIX_PMAP_END ended up being used.
>
> While touching this area also add a check for fixmap and boot FDT area
> to not only not overlap, but to have at least one (unmapped) page in
> between.
>
> Fixes: 4f17357b52f6 ("xen/arm: add Persistent Map (PMAP) infrastructure")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
