Re: [PATCH v3 2/2] x86/fpu: Split fpu_setup_fpu() in three

[Jan Beulich <jbeulich@xxxxxxxx>]

On 13.08.2024 16:21, Alejandro Vallejo wrote:
> It was trying to do too many things at once and there was no clear way of
> defining what it was meant to do. This commit splits the function in three.
> 
>   1. A function to return the FPU to power-on reset values.
>   2. A function to return the FPU to default values.
>   3. A x87/SSE state loader (equivalent to the old function when it took a 
> data
>      pointer).
> 
> While at it, make sure the abridged tag is consistent with the manuals and
> start as 0xFF.
> 
> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> ---
> v3:
>   * Adjust commit message, as the split is now in 3.
>   * Remove bulky comment, as the rationale for it turned out to be
>     unsubstantiated. I can't find proof in xen-devel of the stream
>     operating the way I claimed, and at that point having the comment
>     at all is pointless

So you deliberately removed the comment altogether, not just point 3 of it?

Jan