[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] automation: add default QEMU_TIMEOUT value if not already set


  • To: Stefano Stabellini <stefano.stabellini@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Fri, 16 Aug 2024 09:11:36 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0FEyTELotu+c1MkQ841FkxFnA8pIZ1DEe1XapuEt3bs=; b=mFBBX+AslPYLnLhYnMZmQUXVi9uG2KgJeTGjR2GhA1AFBoSa8m9Y5XVKAfycVco86z4z0t2IxIUROlahBWCKgvlTf7aeSz5ihAk2Tq0KRkq9jgtc4jDmBnJx0/RUyIFYH8+H/vIXWF6ETPYu0A+GBHWbM9UE8sKKgGt3rZBfT1VaiKWoYrrG1q/wTjx/aAXV6sG/o9PXYueCCNaBf31MwNFaqxwXE+BnoTlv0s6iPPpaGMx9XJJ6ubyly9YWMX7qVEW+jGAdyLtOfFCn263l9DsIq1vx5b95qxZdc1nQ1clTFNnXAwKUCGyeynXu9iwtLALt7/c7jyycWmLFpKpcwA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dB1WdUaX/yhvTdYLy/1W3A37jCGu2qSZWVhJBeJ+lhIH+2LwVf/aHckVSmL7/NckDg1FyhoSVTDPtGA8LVJW+cWns4ew4CV6VTbjhWxhXV9Ct7BKp2sALbyHhLKe3BvDMpIN5jJh7tG3Fom/Y851TZ4i/XIQdm6TwdeBlykQDQLUw5Xp5MPCas4n/fi7/aKItaimjHMQQM8hu48xf5frNSA9i/IwmQ3Y2dLxVTE0y8v+wMYw4aFDveDhAmtF5aK1jJE5BduFrW9e+daMgyySxr8Z5lNLKCf6xf0i5qnXpzt3EuRkSLSSiR9lwYfHeV3gwV6fktMjKgPDJKuUfY/f/A==
  • Cc: <sstabellini@xxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Fri, 16 Aug 2024 07:12:20 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 16/08/2024 03:00, Stefano Stabellini wrote:
> The expectation is that QEMU_TIMEOUT should be set as a Gitlab CI/CD
> variable but if not we should be able to run the pipeline anyway.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> ---
>  automation/scripts/qemu-key.exp | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/automation/scripts/qemu-key.exp b/automation/scripts/qemu-key.exp
> index 35eb903a31..787f1f08cb 100755
> --- a/automation/scripts/qemu-key.exp
> +++ b/automation/scripts/qemu-key.exp
> @@ -1,6 +1,10 @@
>  #!/usr/bin/expect -f
>  
> -set timeout $env(QEMU_TIMEOUT)
> +if {[info exists env(QEMU_TIMEOUT)]} {
> +    set timeout $env(QEMU_TIMEOUT)
> +} else {
> +    set timeout 1500
> +}
>  
>  log_file -a $env(QEMU_LOG)
>  

Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.