[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] automation: update xilinx tests to use expect
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: "Lira, Victor M" <VictorM.Lira@xxxxxxx>
- Date: Wed, 28 Aug 2024 18:12:45 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yrIrLs/kUauWM077ChCd602fJVbM6WoSGrQ0TaHlR+0=; b=NWaa97XntQeOUo2nEN/2sHzvwg+L201KThXFM1d/e+Wzn/884da/Uh1WezKzsXO0LvaaUUCJyqixDIsrEbmI4FkzFnvifuMCpl0WuJXcYSlxXkhyckxnmUeev8iQKR3XkWLdE0u740AnRJTyfONi219e3x11qVd3TE63jymWUfoJuzjtf1ArLB/bvVvlvWV9V1xQEqFp5GXRACsLEmzU7jwLxB2rvLqTSdj+3g4uGLZWptDQwjM+JCQSBQaD1sKEuNTR0bbuZn9PWdJ8q1NJQH48OKrdVbQleFfudrI5pIg+fIa4Z6JfRjVMCGPWZRznWXv0NWANyKybVNgugamLAw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Eg66WHJuH3lFr4odXsW/JUXJw/I8rVy3vRfCUd0w4J8ttuPN8Jo6w2CBZ/D6uFeKxwWpjMkm1hudffORO66AyrxmxTZ9gTeiA5mjZ5LDUtThsxrY/rScXnY5XqnHricIwl7LlktmAoR2ZAlBW2a4yvOEXu0ZniYByLigdi+RzubqRy0YEikkx8MinUHcSr3xtq6oTGkByqd0UiPlDQ/ZIwoK7xenmNcL+Rb4dMjiCK8w2GjXm803hvH1wit0G6vgqHXuhDCnbxG5EFcSLIU4mZdRx4LC2Z8hvEh5RUmzG7D+YuN3Cf5iIX8WSJrMGo1LLfjHWhYev8j7iARFeUN3xg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 29 Aug 2024 01:13:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 8/28/2024 5:25 PM, Stefano Stabellini wrote:
xilinx-smoke-dom0-x86_64-gcc-debug:
extends: .xilinx-x86_64
+ variables:
+ TEST_TIMEOUT: 500
I think we need to add something similar for .xilinx-arm64
The timeout should be set in test.yaml otherwise we'll default to 1500
I will add the missing variable.
t TEST_LOGFILE="smoke.serial"
+mkfifo console
+sed 's/\r\+$//' < console &
+./automation/scripts/console.exp > console
+TEST_RESULT=$?
+sh /scratch/gitlab-runner/${TEST_BOARD}.sh 2
+exit ${TEST_RESULT}
Isn't this sufficient? Why do we need the fifo?
export TEST_PASS_MSG="${PASS_MSG}"
export TEST_CMD_START="cat ${SERIAL_DEV}"
export TEST_LOGFILE="smoke.serial"
./automation/scripts/console.exp | sed 's/\r//'
TEST_RESULT=$?
sh /scratch/gitlab-runner/${TEST_BOARD}.sh 2
exit ${TEST_RESULT}
In the line
./automation/scripts/console.exp | sed 's/\r//'
The exit status gets set to that of "sed" instead of "console.exp", and it could
produce a false result. This was one way to achieve the result while avoiding
bash-isms.
Victor
|
