[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2 1/5] x86/Kconfig: introduce CENTAUR, HYGON & SHANGHAI config options


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>
  • Date: Thu, 29 Aug 2024 12:29:54 +0300
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QX60cFgxvS1j/hQCViRG5wRI6bX/9dzwIwqyk0nbFgo=; b=JFq/nb9ftMHUBUeuFcklZl+nNbzH4wCzzNIAhw1PAS239NUy3Mq3y+wNKHZ7aIaAoZebOP2dNBvLBc2O5YdfeS+5w8yQTDZIeX60WvJG4qDO5ukGkYRR39G40vyrmjUxU3xuzd8mWY3FuA+N5JaYotpj44yZ8h81TCsHluzDeD2EoBUB+cpNZI/VnK2IvwUK+IxAtNHIYZAP71XftX5hdMsdH98lDb0q1q3SbxKQdEj97NZwrhGEimvpJHx9IbcdJmbHn/JomMnnKOmWyNtRVq+hGdlQwg8uts76ZVEJCEv/t9GjHxKKUx8sOdgVh5craa1Of7CE6uvFo6Sxom+jHA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tHQ2ZsB4tDp0SkJYU++PMUCq0fUef0W4pDlOeNRTZ1asCRMSKmJL/zEhAZF1GsIb9pjkpamLI6c+v2jUmKbfYJsvy4BTgvuKMSGPigeeLWYTR7PN+t7qSPbtUsS34iVl6gcq+WbZyIjDxiuTEqXQAyHct/33DewGiPxIRHAvwiOo9u3SXSesqQznGmYw/JQvWwQVOdtubPT+hpL3iiwSor4OtUp2XGM3+XzlWGqx6keQ6niju7Q+to+QBfS9ZizrenAkoA4RWFpJjuiLQof1woR/HE2UF/m5SlAw/GYCL9hgDOT3IVQ+U6WjHHj3NKDTyStw6QIoddtAiB7/iI3o6w==
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 29 Aug 2024 09:30:24 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

19.08.24 11:53, Jan Beulich:
On 16.08.2024 13:10, Sergiy Kibrik wrote:
--- a/xen/arch/x86/Kconfig.cpu
+++ b/xen/arch/x86/Kconfig.cpu
@@ -10,6 +10,25 @@ config AMD
          May be turned off in builds targetting other vendors.  Otherwise,
          must be enabled for Xen to work suitably on AMD platforms.
+config CENTAUR
+       bool "Support Centaur CPUs"
+       default y
+       help
+         Detection, tunings and quirks for VIA platforms.
+
+         May be turned off in builds targeting other vendors. Otherwise, must
+          be enabled for Xen to work suitably on VIA platforms.
+
+config HYGON
+       bool "Support Hygon CPUs"
+       depends on AMD
+       default y
+       help
+         Detection, tunings and quirks for Hygon platforms.
+
+         May be turned off in builds targeting other vendors. Otherwise, must
+          be enabled for Xen to work suitably on Hygon platforms.
+
  config INTEL
        bool "Support Intel CPUs"
        default y
@@ -19,4 +38,14 @@ config INTEL
          May be turned off in builds targetting other vendors.  Otherwise,
          must be enabled for Xen to work suitably on Intel platforms.
+config SHANGHAI
+       bool "Support Shanghai CPUs"
+       depends on INTEL
+       default y
+       help
+         Detection, tunings and quirks for Zhaoxin platforms.
+
+         May be turned off in builds targeting other vendors. Otherwise, must
+          be enabled for Xen to work suitably on Zhaoxin platforms.
+
  endmenu
Imo this re-raises the question of whether it is a good idea to leave out
"CPU" from the names: The more names there are, the more likely it'll become
that going forward we'll run into a naming collision. Andrew, iirc you
were the main proponent for omitting "CPU" - may I ask that you re-consider?

Furthermore I wonder whether "depends on" is appropriate here. This way one
won't be offered e.g. SHANGHAI if earlier on one de-selected INTEL.

I see, then probably I'll use 'select INTEL' here.
And also 'select AMD' for HYGON.

  -Sergiy



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.