Re: Block protocol incompatibilities with 4K logical sector size disks

[Mark Syms <mark.syms@xxxxxxxxx>]

On Mon, 2 Sept 2024 at 09:55, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
>
> > So yes, after more research, having sector in the protocol been a
> > 512-byte size seems the least bad option. "sector_number" and
> > "{first,last}_sect" have been described as is for a long while. Only
> > "sectors" for the size has been described as a "sector-size" quantity.
>
> Thanks for your input.  I would also like to hear from the blktap and
> Windows PV drivers maintainers, as the change that I'm proposing here
> will require changes to their implementations.

Well, that's a whole big mess isn't it ;( FWIW, it's tacitly assumed
that tapdisk is only running on 512 or 512e storage as its primary use
case is VHD and that driver explodes spectacularly on 4KN. So,
hardening those implicit conditions into hard explicit ones seems like
an entirely reasonable thing.

Mark