[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 06/12] x86/mm: address violations of MISRA C Rule 16.3



On 10/09/24 16:55, Jan Beulich wrote:
On 10.09.2024 12:08, Federico Serafini wrote:
Address violations of MISRA C:2012 Rule 16.3:
"An unconditional `break' statement shall terminate every
switch-clause".

No functional change.

Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
---
  xen/arch/x86/mm/guest_walk.c     | 1 +
  xen/arch/x86/mm/hap/hap.c        | 2 +-
  xen/arch/x86/mm/hap/nested_hap.c | 1 +
  xen/arch/x86/mm/paging.c         | 2 +-
  4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c
index fe7393334f..bc032d697c 100644
--- a/xen/arch/x86/mm/guest_walk.c
+++ b/xen/arch/x86/mm/guest_walk.c
@@ -497,6 +497,7 @@ guest_walk_tables(const struct vcpu *v, struct p2m_domain 
*p2m,
              paging_mark_dirty(d, gw->l4mfn);
              hvmemul_write_cache(v, l4gpa, &gw->l4e, sizeof(gw->l4e));
          }
+        break;
  #endif
      }

This wants inserting after the #endif, I think. If you agree, I'm happy to
adjust while committing. With the adjustment:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

You are right, thanks.

--
Federico Serafini, M.Sc.

Software Engineer, BUGSENG (http://bugseng.com)



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.