Re: [PATCH v1 2/3] xen/riscv: add section for device information in linker script

[oleksii.kurochko@xxxxxxxxx]

On Thu, 2024-09-12 at 17:31 +0200, Jan Beulich wrote:
> On 11.09.2024 12:04, Oleksii Kurochko wrote:
> > Introduce a new `.dev.info` section in the RISC-V linker script to
> > handle device-specific information.
> > This section is aligned to `POINTER_ALIGN`, with `_sdevice` and
> > `_edevice`
> > marking the start and end of the section, respectively.
> > 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> 
> This (and patch 1) is okay in principle, provided the description
> actually
> also says "why", not just "what". Placing past .bss is questionable,
> though.
> 
> Overall, however, this probably could do with abstracting by a macro
> in
> xen/xen.lds.h, then also to be used by Arm.
It make sense. Thanks. I will add the macro in the next patch version.

Thanks.

~ Oleksii