[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 2/2] xen/swiotlb: fix allocated size



The allocated size in xen_swiotlb_alloc_coherent() and
xen_swiotlb_free_coherent() is calculated wrong for the case of
XEN_PAGE_SIZE not matching PAGE_SIZE. Fix that.

Fixes: 7250f422da04 ("xen-swiotlb: use actually allocated size on check 
physical continuous")
Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
---
V2:
- new patch
---
 drivers/xen/swiotlb-xen.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index ddf5b1df632e..faa2fb7c74ae 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -147,7 +147,7 @@ xen_swiotlb_alloc_coherent(struct device *dev, size_t size,
        void *ret;
 
        /* Align the allocation to the Xen page size */
-       size = 1UL << (order + XEN_PAGE_SHIFT);
+       size = ALIGN(size, XEN_PAGE_SIZE);
 
        ret = (void *)__get_free_pages(flags, get_order(size));
        if (!ret)
@@ -179,7 +179,7 @@ xen_swiotlb_free_coherent(struct device *dev, size_t size, 
void *vaddr,
        int order = get_order(size);
 
        /* Convert the size to actually allocated. */
-       size = 1UL << (order + XEN_PAGE_SHIFT);
+       size = ALIGN(size, XEN_PAGE_SIZE);
 
        if (WARN_ON_ONCE(dma_handle + size - 1 > dev->coherent_dma_mask) ||
            WARN_ON_ONCE(range_straddles_page_boundary(phys, size)))
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.