[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2] x86: Put trampoline in separate .init.trampoline section
On 16.09.2024 11:11, Frediano Ziglio wrote: > On Sat, Sep 14, 2024 at 7:16 AM Jan Beulich <jbeulich@xxxxxxxx> wrote: >> On 11.09.2024 11:55, Frediano Ziglio wrote: >>> + DECL_SECTION(.init.trampoline) { >>> + *(.init.trampoline) >>> + } PHDR(text) >>> + >>> #ifndef EFI >> >> If this is to be a separate section also for ELF, I think that >> wants mentioning explicitly. "Easily disassemble" is too vague >> a reason for my taste. > > It's not clear if either you changed your mind on that reason or if > the commit message is not clear. I'm assuming the latter, I'll improve > the commit message. > Not clear why you specify "ELF" in the above sentence, I mean, why > should it matter if it applies to EFI and/or ELF? And why having it > different from ELF to EFI? Why do we fold sections at all? We could keep them all separate, leading to a big section table with -f{function,data}-sections. If you want to change something, you need to clarify why the change is being made, for every part that is affected. We don't have a need for the separate section in ELF, so it becoming one without at least saying so (and ideally also why) it might look like an oversight / mistake to someone later stumbling across that commit. Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |