Re: [PATCH v2] x86/efi: Use generic PE/COFF structures

[Milan Đokić <milandjokic1995@xxxxxxxxx>]

Hello Frediano,
Thank you for your feedback
>
> On Thu, Sep 19, 2024 at 11:42 AM Milan Đokić <milandjokic1995@xxxxxxxxx> 
> wrote:
> >
> > Hello everyone,
> >
> > Any comments on v2 patch?
> > Just checking if you missed this email or didn't have time for review.
> >
> > BR,
> > Milan
> >
>
> Hi,
>   it does look good to me.
> I don't like the "#include "../../../include/efi/pe.h"" line, but I
> don't exactly know how to add a -I option.
>
Yes, this does look bad. Although, I don't see that we have other
options with the current build setup. mkreloc is built as a separate
binary and it's added to the hostprogs list, for which we are not able
to add additional flags. Relative paths are also used for other
hostprogs when some local xen file needs to be included. Only solution
which I see here is to have a separate makefile for mkreloc, but I
would say that this is also not a good option, since we will separate
mkreloc from other hostprogs in build config. If someone has some
better idea here we shall be happy to apply it.
> There are some spurious space changes that could be removed but okay
> for the rest.
>
Space changes are caused by our formatter which aligned this file
according to coding guidelines. We can revert those if formatting
needs to be done separately.

Best regards,
Milan