[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/4] xen/arm: mpu: Implement a dummy enable_secondary_cpu_mm
- To: Jan Beulich <jbeulich@xxxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Tue, 24 Sep 2024 12:54:14 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bl4tMRHbIutj3UKY12jrVuBN+pLKaojPQ5tBPE6ose4=; b=MyOo5+07IqkcuiqcZHgVxObCqn6RP40c5iGKA4gj8HxqRRBMvh1QijN64YPGc2CkW56M76TLPwkMsm2zBqsotLkOZ2icQw5eEu44gABB66YZz2X1b/DlcfV8B20J2U8O4/SKWbmT4oWa+3bYroz4hLnWqCuRh0dWIl5VsakiiSTE+OU5MjH0MOuQ4iODIraVSB0q1JurGh/ys1FgeoO2chgzC10PP3FCGOmPWtTEgNneBHjbnVzx1VXvbLnB4uvaL0JVbgKr0oGDOz18mzE2DtMl+w4yYExGY7jZNh24iaB0DYoNc2Go/+pPT5AyNccASvubGrDceq/IT9OLRPzRww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UFIkf0QohFD1Eq66yiiqjHuBRtAtRtTq/omj1iw2hTFlbjMKFvXELRldzVyOtCN6Hn4vrayWDZp5L+I+hnWD/50gr/AWLaF94McOEJ3Tl/SmDPKeGzUB9bROdfmXAePB8lssk8G9obBA0Q1N9wVcKzT3gwrefl6DoZ/JGTQohDOLZ3GiWtE4vUoCQfpPf2Tlrs0oOq0p/eDGkQDkQy4MEZomhp6WvRM2B3N2BmQnDW9JJnaFNtT+otMqA7yyKehu25QlYwPL9k3WsdPLoVQfbNNDIHlDd0DEsiWv/4rO9wbAvj1a6p0ur9DA9KzbjnbS9DYFLajn9R0hE1c7Eixoww==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Sep 2024 11:54:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jan,
On 23/09/2024 11:23, Jan Beulich wrote:
On 18.09.2024 19:51, Ayan Kumar Halder wrote:
Secondary cpus initialization is not yet supported. Thus, we print an
appropriate message and put the secondary cpus in WFE state.
Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
---
Changes from :-
v1 - 1. NR_CPUS is defined as 1 for MPU
Not quite, what you do is ...
--- a/xen/arch/Kconfig
+++ b/xen/arch/Kconfig
@@ -11,6 +11,7 @@ config NR_CPUS
default "8" if ARM && RCAR3
default "4" if ARM && QEMU
default "4" if ARM && MPSOC
+ default "1" if ARM && MPU
default "128" if ARM
help
Controls the build-time size of various arrays and bitmaps
... merely set the default. I wonder how useful that is, the more that
- as per the description - this is temporary only anyway.
Yes, I can enforce a build time check like this.
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -295,6 +295,12 @@ void asmlinkage __init start_xen(unsigned long
fdt_paddr)
struct domain *d;
int rc, i;
+ /*
+ * Currently MPU does not support SMP.
+ */
+#ifdef CONFIG_MPU
+ BUILD_BUG_ON(NR_CPUS > 1);
+#endif
dcache_line_bytes = read_dcache_line_bytes();
Does this look ok ?
- Ayan
|
