Re: [PATCH v4 2/6] xen: define ACPI and DT device info sections macros

[oleksii.kurochko@xxxxxxxxx]

On Fri, 2024-09-27 at 09:28 +0200, Jan Beulich wrote:
> On 26.09.2024 18:54, Oleksii Kurochko wrote:
> > --- a/xen/include/xen/xen.lds.h
> > +++ b/xen/include/xen/xen.lds.h
> > @@ -120,6 +120,14 @@
> >  
> >  /* List of constructs other than *_SECTIONS in alphabetical order.
> > */
> >  
> > +#define ACPI_DEV_INFO(secname)  \
> > +  . = ALIGN(POINTER_ALIGN);     \
> > +  DECL_SECTION(secname) {       \
> > +      _asdevice = .;            \
> > +      *(secname)                \
> > +      _aedevice = .;            \
> > +  } :text
> > +
> >  #define BUGFRAMES                               \
> >      __start_bug_frames_0 = .;                   \
> >      *(.bug_frames.0)                            \
> > @@ -137,6 +145,14 @@
> >      *(.bug_frames.3)                            \
> >      __stop_bug_frames_3 = .;
> >  
> > +#define DT_DEV_INFO(secname)    \
> > +  . = ALIGN(POINTER_ALIGN);     \
> > +  DECL_SECTION(secname) {       \
> > +       _sdevice = .;           \
> > +       *(secname)              \
> > +       _edevice = .;           \
> > +  } :text
> > +
> >  #ifdef CONFIG_HYPFS
> >  #define HYPFS_PARAM              \
> >         . = ALIGN(POINTER_ALIGN); \
> 
> Michal's comment made me notice that I overlooked the section names
> being
> macro parameters. Why's that?
I wanted to give ability for architecture to choose the name but now I
am realized that it isn't corrected as common code is using specific
names ".adev.info" and ".dev.info".

I will prepare the new version of patch series with dropped macro
parameter and just hardcode the name of the section inside the macros.

~ Oleksii