[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] x86/hvm: make ACPI PM timer support optional


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>
  • Date: Mon, 30 Sep 2024 14:03:14 +0300
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w91KXap/SWein/qOOwiA3At4+nxmeGCrGRMelOsN/zk=; b=tvkp61lYMkDiwrb58ZZdiQdtk8bB2+FUKAl7VPjP/btkrqQypszS2VurEGuOq8I4Lbtpmx0G0lmcUMYtejwlEIoQvF0B0OsztkzAxbKRV7PfsbqtMEI8Jw03QrdLZj/0JWdXN5KA0wk2pSaNhesOPPQnQc1k1SUQVktcU0i/i9eMvYr/olAVtZZoDOxkdSM2aRJ7o0OywAuE1SZ8kqRrBSKuVmDdzMbb5x4AlMiPL6cPNIlaUGYO0HgbhZYcUKplh2BX8dvU279ja8pQOWXpnBt2Si6shNxbb9I+oJNjiBR0bwdbOZJ8JntMltVJCQmjB4NPVOJbTPFL35DI6WktDQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J5ZFatWQQ2xpNnPFMfRECLJImNCFQ46HOfK9e4N//arQwtj6Wpv6c7Bu99gB79VToX1obWXJnRFBIxOwCAwl4+E5Rpv83/x96UkfqQ8rXpd11TrL7tK9ncu8olIbbG5rtPzpE8VTy0QvtNXoK6krX4dnFvuVnGCxIjQwen+061j1AZtVwznGvNxOs8uXDIg70fK9MYJXm4UyoIlR6ISOx7ZEk6Z4jyZ/2XBzWNzBtCa2UalAv6RO8Gb0fFhnI3xkktWlVh01DG1DBXuqNdjjgKIsw1iRaO8/L56v7EE619GCdvdW+zqTMoUrHWSRDnURWbhurKfJ4M52IK84+RoUAw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 30 Sep 2024 11:03:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

27.09.24 12:44, Jan Beulich:
(probably with X86_PMTIMER option depending on PV)
HVM you mean?

I wanted to do it like this:

--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -386,7 +386,7 @@ config ALTP2M
            If unsure, stay with defaults.

   config X86_PMTIMER
-       bool "ACPI PM timer emulation support" if EXPERT
+       bool "ACPI PM timer emulation support" if EXPERT && PV
          default y
          depends on HVM
          help

to allow it to be disabled when PV is on and prevent situation when pvh
domain can't be created because !PV and hvm domain can't be created
either without emulated timer.
How does PV matter for this "depends on HVM" setting?

Options are dependant on HVM option, because pmtimer & stdvga drivers are part of HVM support code. At the same time these options are allowed to be de-selected when PV/PVH enabled, because only PV/PVH domains can be created when stdvga or pmtimer are disabled (if both PV & any emulated device are disabled one would end up with weird system that can't create any VM).
So that's the idea behind making all these dependencies.

  -Sergiy





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.