[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 3/6] xen/arm: create dom0less virtio-pci DT node


  • To: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
  • Date: Tue, 1 Oct 2024 15:30:30 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DIGfvN+rRVqlOhjfJJqu1l0NsjX7EGw/d/MABEMRqs8=; b=y1WqywAvTZwvEUUxKxZlZJhP24k2Hg7C/ob/eAOmS0dcnZ9/NRfoHKkMT6kdXt1Id3D0qb0HE015QdlDFZMD+KC1pxL41VEbu59Sv4N0/HPchZ9fDror7QGY+Q6AmZvaMLjWqc7rQjaKsnPxoU/0Q8/I2ml8rwf3dWWnEyzqcLD+/ThC3U5s5Rwy023/hbyYZYzr0HYKfV9z8OrWA+FALaRCqrsGTbK6ndYMsPOTgQWT/gNda0+8F1lXQzrcNKR6V+FBZ5nQz/F9nNFp9udv/Xc0gV1pH5fEwoWi1NzWfkpzcZpDw4lTYXtcxtX+HfYhz9p1PbbnaqJHpZOibOuMfQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=URVL9BRF5g+3/453yv+XgVlvsr6YERJGdBcbkZehjHnzRTOnYazMsobW8O7FFVmaGeUOZ8CbaGou1W04of5pqbi8tX/46Ip3rCVCFjftcP9f1Hjpr61vk/Z2PriGcEtniK0i+iPXs9ZHJVRTHkhh2g/Zgkz81vNAqmz4/uZ0l+dbga16dJ4154ybmhinNM8B2fLqyrkQcbekLfh+S28FGzXhdc4qK4B6JcajStTFTEJObz4ibxtDDtLvrLlmzTc1VTETbNIsBGh0lQfySfGyRQOtpwpCJMQNn1Ad1rh1YjjhZ3wf29MDhAcQ+0zIDj2Rho3qFoEb383/NwdyDFWFvg==
  • Cc: <sstabellini@xxxxxxxxxx>, <julien@xxxxxxx>, <bertrand.marquis@xxxxxxx>, <michal.orzel@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <edgar.iglesias@xxxxxxx>
  • Delivery-date: Tue, 01 Oct 2024 19:31:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 9/24/24 12:23, Edgar E. Iglesias wrote:
> diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c
> index 09b65e44ae..dab24fa9e2 100644
> --- a/xen/arch/arm/dom0less-build.c
> +++ b/xen/arch/arm/dom0less-build.c
> @@ -586,6 +586,189 @@ static int __init domain_handle_dtb_bootmodule(struct 
> domain *d,
>      return res;
>  }
>  
> +static int __init make_virtio_pci_domU_node(const struct kernel_info *kinfo)
> +{
> +    void *fdt = kinfo->fdt;
> +    /* reg is sized to be used for all the needed properties below */
> +    __be32 reg[(1 + (GUEST_ROOT_ADDRESS_CELLS * 2) + GUEST_ROOT_SIZE_CELLS)
> +               * 2];
> +    __be32 irq_map[4 * 4 * 8];

Why two separate arrays on the stack? It looks like they're used for the
same purpose, so I think we may as well keep the bigger one and get rid
of the smaller.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.