[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 1/2] x86/boot: Rewrite EFI/MBI2 code partly in C


  • To: Frediano Ziglio <frediano.ziglio@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Wed, 2 Oct 2024 10:31:50 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1727879519; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=i35ARlYwDuWmwyEfs1kR/M+7Lobwd15oia36lQLOm/s=; b=OWLIacYWFnATDgU58ixgAocfdecVCsztsrbNdKyN6Uchqw/gSks66lafbOQ+JrhEVSZb2gd+rU/VioCs5ElYTiz6QBN+2XRLNgjRKIjYAeunkDSGOP9mKxwVJ5jKxFu+Utk1E2LcRaKYSITTMI2jmo3eriFVjwVgSphLN2fZl4k=
  • Arc-seal: i=1; a=rsa-sha256; t=1727879519; cv=none; d=zohomail.com; s=zohoarc; b=Yz+QYC9ymBwvZKj43kKwKFR9mbNoT6jw4xhPuxZ+7PRHbg5ph0fJ2oT9fzwgXzWOi4HeFO8/3RG+36ulndY6lvPe6JuSf5Mm8NwUIWchz7XlHs5GbKMO8bYgqkEpq252iSn1IS6pymnqsnEcrfWtXq6yHZfYG39ZVFrHQd4L1Es=
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 02 Oct 2024 14:32:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/1/24 06:22, Frediano Ziglio wrote:
No need to have it coded in assembly.
Declare efi_multiboot2 in a new header to reuse between implementations
and caller.

Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxx>

I unfortunately do not have time to test this myself, but I have given a read through and it looks good to me. I will give it an R-b and let Marek provide the A-b when he is comfortable that CI failure is an artifact of the test system and not this series.

Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.