[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v7 0/2] x86/boot: Reduce assembly code
On Thu, Oct 03, 2024 at 10:27:15AM +0100, Frediano Ziglio wrote: > On Thu, Oct 3, 2024 at 2:11 AM Marek Marczykowski-Górecki > <marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > On Wed, Oct 02, 2024 at 04:27:19PM +0100, Frediano Ziglio wrote: > > > On Wed, Oct 2, 2024 at 3:04 PM Marek Marczykowski-Górecki > > > <marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > On Tue, Oct 01, 2024 at 11:22:37AM +0100, Frediano Ziglio wrote: > > > > > This series came from part of the work of removing duplications > > > > > between > > > > > boot code and rewriting part of code from assembly to C. > > > > > Rewrites EFI code in pure C. > > > > > > > > The MB2+EFI tests on Adler Lake fail with this series: > > > > https://gitlab.com/xen-project/people/marmarek/xen/-/pipelines/1478766782 > > > > Looking at the VGA output (unfortunately not collected by the test > > > > itself) it hangs just after bootloader, before printing anything on the > > > > screen (or even clearing it after bootloader). The serial is silent too. > > > > > > > > > > I tried multiple times to take a look at the logs, but I keep getting > > > error 500. > > > > 500? That's weird. Anyway, serial log is empty, so you haven't lost > > much. > > I'm getting pretty consistently. I can see the full pipeline, but not > the single logs. I tried with both Firefox and Chrome, I also tried > from home (just to check for something like firewall issues), always > error 500. > > > But also, I've ran it a couple more times and it is some regression. > > Staging reliably passes while staging+this series fails. > > > > Unfortunately I don't have any more info besides it hangs before > > printing anything on serial or VGA. Maybe it hanging only on Intel but > > not AMD is some hint? Or maybe it's some memory layout or firmware > > differences that matter here (bootloader is exactly the same)? > > FWIW some links: > > successful staging run on ADL: > > https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/7980146338 > > failed staging+this run on ADL: > > https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/7980330394 > > successful staging run on Zen3+: > > https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/7980146359 > > successful staging+this run on Zen3+: > > https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/7980146359 > > > > Furthermore, I tried with 2 additional machines in our Lab, one Intel, > another AMD, both working for me. > Either your compiler did something different or something special on > the firmware. > > I could try downloading your executables and machines there, but as I > said, I'm getting error 500 (not sure if we package artifacts). > > Can you try without last commit ? Yes, this seems to work: https://gitlab.com/xen-project/people/marmarek/xen/-/pipelines/1480052345 -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab Attachment:
signature.asc
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |