[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 00/19] Update header guards bases on new coding style


  • To: Frediano Ziglio <frediano.ziglio@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 4 Oct 2024 08:23:57 +0200
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 04 Oct 2024 06:24:08 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.10.2024 19:59, Frediano Ziglio wrote:
> With the help of some scripts and manual checking I updated header guards.
> 
> As the changes are pretty large patch was split based on maintainers
> to reduce mail spamming.
> 
> Excluded public headers from the update, they are API, software like
> Qemu will fail to compile if changed.

Interesting - the first patch I peeked at, ...

> Changes since v1:
> - make all commit compile;
> - exclude public headers, their guard is not an API.
> 
> Frediano Ziglio (19):
>   xen: Update header guards - Generic
>   xen: Update header guards - X86
>   xen: Update header guards - ACPI
>   xen: Update header guards - ARGO

... this one, adjusts a public header. And the diffstat ...

>  xen/include/public/arch-arm.h                           | 6 +++---
>  xen/include/public/arch-arm/hvm/save.h                  | 4 ++--
>  xen/include/public/arch-arm/smccc.h                     | 6 +++---
>  xen/include/public/arch-x86/cpufeatureset.h             | 6 +++---
>  xen/include/public/arch-x86/cpuid.h                     | 6 +++---
>  xen/include/public/arch-x86/guest-acpi.h                | 6 +++---
>  xen/include/public/arch-x86/hvm/save.h                  | 6 +++---
>  xen/include/public/arch-x86/hvm/start_info.h            | 6 +++---
>  xen/include/public/arch-x86/pmu.h                       | 6 +++---
>  xen/include/public/arch-x86/xen-mca.h                   | 6 +++---
>  xen/include/public/arch-x86/xen-x86_32.h                | 6 +++---
>  xen/include/public/arch-x86/xen-x86_64.h                | 6 +++---
>  xen/include/public/arch-x86/xen.h                       | 6 +++---
>  xen/include/public/argo.h                               | 4 ++--
>  xen/include/public/vm_event.h                           | 6 +++---

... also contradicts that statement. Please clarify.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.