Re: [PATCH 3/3] x86/boot: Use boot_vid_info and trampoline_phys variables directly from C code

[Frediano Ziglio <frediano.ziglio@xxxxxxxxx>]

On Mon, Oct 7, 2024 at 11:06 AM Frediano Ziglio
<frediano.ziglio@xxxxxxxxx> wrote:
>
> On Sat, Oct 5, 2024 at 2:43 PM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> 
> wrote:
> >
> > On 05/10/2024 9:02 am, Frediano Ziglio wrote:
> > > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
> > > index ade2c5c43d..dcda91cfda 100644
> > > --- a/xen/arch/x86/boot/head.S
> > > +++ b/xen/arch/x86/boot/head.S
> > > @@ -510,22 +510,10 @@ trampoline_setup:
> > >          mov     %esi, sym_esi(xen_phys_start)
> > >          mov     %esi, sym_esi(trampoline_xen_phys_start)
> > >
> > > -        /* Get bottom-most low-memory stack address. */
> > > -        mov     sym_esi(trampoline_phys), %ecx
> > > -        add     $TRAMPOLINE_SPACE,%ecx
> > > -
> > > -#ifdef CONFIG_VIDEO
> > > -        lea     sym_esi(boot_vid_info), %edx
> > > -#else
> > > -        xor     %edx, %edx
> > > -#endif
> > > -
> > >          /* Save Multiboot / PVH info struct (after relocation) for later 
> > > use. */
> > > -        push    %edx                /* Boot video info to be filled from 
> > > MB2. */
> > >          mov     %ebx, %edx          /* Multiboot / PVH information 
> > > address. */
> > > -        /*      reloc(magic/eax, info/edx, trampoline/ecx, video/stk) 
> > > using fastcall. */
> > > +        /*      reloc(magic/eax, info/edx) using fastcall. */
> > >          call    reloc
> > > -        add     $4, %esp
> > >
> >
> > Please split this patch in two.  Just for testing sanity sake if nothing
> > else.
> >
>
> Sorry, it's not clear how it should be split. What are the 2 parts ?
>

Never mind, understood, one variable per commit.

Frediano