[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 03/44] x86/boot: move cmdline to boot info


  • To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Mon, 7 Oct 2024 14:09:08 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DHQUuRuCSKQUILuLwdP1XnGT51mR8amYHJG7lPGd90I=; b=Y7FLm0ZgfjwV9P+OJufMl08XekaRWYn5mkT4mOd3GHNUDU6J/U2DQvW3gZTvfzmrWnXBSj0ZuoK2m3YngY7Sbt9B9HWA7JY9Rot8wYabDJ5X+HHFEf2I0/AxZW5UKDw8rPgzU/nq5SFydTsBd5j9TChrT90ODSI+ELUEyskqU4rkRK/LpgNPjVBWhtWuOt7oK6+FNbnFlU0oMhEF7qcrvypbMvnBg13NEMsekqroJrW7wJ5dwXPoriaxIZvCQ6mOQbiWjGblQBON7TsXH2UlSjcf/3hun8/mYsiLOCigwRHWEcQ21D83jsmFdlL4IKpiuAmNUuP0d2DtAdzgQv/KOw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qnRAXJ+i/iG9axzbSJiTUFxDy0YSPE53V6yS8hX7uCnjoam84Zy+umxu6mhdDdHzyl4x7i03Zoqdcl/LAydcuo76gBuUGfKG4x/aJK5zLnC1PbdQAq1+TeS0jXL/QyU6C4mgySX2NDkJy4i/v4fvN6pecr7W3zq0tsGeV3U4IwX1cidIvT3+fL25uCaGGeJrpd8bMvz2Vsfht2OyKBIg/3d1SJdd8lU4WLrPzvVnYSPeSCF8DmuWUm0JyVLDgkOZlPn29qrXyLK2d8TA6wfp6BdYUE+hc2tNrfWzTNCBpKhfitxyQQH+DX2sJTGW2UTdyfTjnCk1RcDnCtkPhXiSPA==
  • Cc: <christopher.w.clark@xxxxxxxxx>, <stefano.stabellini@xxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 07 Oct 2024 18:09:24 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2024-10-06 17:49, Daniel P. Smith wrote:
Transition Xen's command line to being held in struct boot_info.

No functional change intended.

Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---

  #endif /* __XEN_X86_BOOTINFO_H__ */
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index aafc098ca268..0921f296075f 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -274,6 +274,8 @@ static int __init cf_check parse_acpi_param(const char *s)
  }
  custom_param("acpi", parse_acpi_param);
+static const char *cmdline_cook(const char *p, const char *loader_name);

Is there a reason not to move cmdline_cook() (and loader_is_grub2()) earlier to avoid this forward declaration?

Everything else looks okay.

Regards,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.