Re: [PATCH v2] x86/APIC: Switch flat driver to use phys dst for ext ints

[Matthew Barnes <matthew.barnes@xxxxxxxxx>]

On Tue, Oct 08, 2024 at 03:47:41PM +0200, Jan Beulich wrote:
> On 07.10.2024 16:34, Matthew Barnes wrote:
> > --- a/xen/arch/x86/include/asm/genapic.h
> > +++ b/xen/arch/x86/include/asm/genapic.h
> > @@ -44,29 +44,11 @@ extern const struct genapic apic_bigsmp;
> >  void cf_check send_IPI_self_legacy(uint8_t vector);
> >  
> >  void cf_check init_apic_ldr_flat(void);
> > -unsigned int cf_check cpu_mask_to_apicid_flat(const cpumask_t *cpumask);
> > +const cpumask_t *cf_check vector_allocation_cpumask_phys(int cpu);
> 
> Why does this decl move to between two flat decls, rather than ...
> 
> >  void cf_check send_IPI_mask_flat(const cpumask_t *cpumask, int vector);
> > -const cpumask_t *cf_check vector_allocation_cpumask_flat(int cpu);
> > -#define GENAPIC_FLAT \
> > -   .int_delivery_mode = dest_LowestPrio, \
> > -   .int_dest_mode = 1 /* logical delivery */, \
> > -   .init_apic_ldr = init_apic_ldr_flat, \
> > -   .vector_allocation_cpumask = vector_allocation_cpumask_flat, \
> > -   .cpu_mask_to_apicid = cpu_mask_to_apicid_flat, \
> > -   .send_IPI_mask = send_IPI_mask_flat, \
> > -   .send_IPI_self = send_IPI_self_legacy
> >  
> >  void cf_check init_apic_ldr_phys(void);
> >  unsigned int cf_check cpu_mask_to_apicid_phys(const cpumask_t *cpumask);
> >  void cf_check send_IPI_mask_phys(const cpumask_t *mask, int vector);
> > -const cpumask_t *cf_check vector_allocation_cpumask_phys(int cpu);
> 
> ... staying where it was, next to other phys ones?

My bad, it's a remnant from an older version of this patch.
There's no reason for the declaration to move.

- Matt