[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 25/44] x86/boot: convert create_dom0 to use boot info
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Tue, 8 Oct 2024 12:52:25 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IBYWX9WX+30T2jZasXYno7vXPVVwV0H7pTZ1vp4nrF4=; b=XXXflTmgyXSeZ283T8EloMyX9KJ6m4QdWU/YK5R/deb1GnAiJmkX9N17CNtmDfbKouMDsojJxjAeRE03/Qbru7uXBfZfGJRFSgYPNboGX503oB7MG7s/RL3vy5rz+p52otcEhTkOwqOOt1Wb4cR7t3XQx+i5mvKH17d4jfnnw/Ha9J25bv1kaKbZFlnPDUk5idkSno3MUt0vGkHQcdO1ZDzkn9VxaZgZ6Whh6WQeAAmA7NrRgvX17/K3Kd2O/1c+P1OKvFboT2ZUVnSkCzb1xhGG1NQSRensmh4Hit9JNMUmTIdLsB51vCU2VX3g++VcE5D6NQLNkIBk1bBeOYb0DA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zJQD4dEe9ArVHGtVT76Yl/3am9V/vivacUidyh9pVBkMtK/NGffOVpmiyboWYSwzPOmnV8gmL4Shfn7KCD5Ls55YKSOoF0sFsJhe9W9nYCET2Ftt4o7L6aEygo9eegHE4H7J6grABo3GOJz0u9ZS54opOV9kChuLQHIib+inBl2moTjfrrKy3hbhGRhFJqvjTdKnvteR6o+9LZ1qco85LFQWBK9ZomU1K8/dnOVZ91Xkm7OgGZOCluMuJwAkE79VG8/ZMm5zKy6F8HSn5omfcMEWR1xSClYyaKffR7SZNAyTzUIKWE3kbOIU6yPukEB6QHNi9LGQO4W/mvzkkA+9dw==
- Cc: <christopher.w.clark@xxxxxxxxx>, <stefano.stabellini@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 08 Oct 2024 16:52:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2024-10-06 17:49, Daniel P. Smith wrote:
This commit changes create_dom0 to no longer take the individual components and
take struct boot_info instead. Internally, it is changed to locate the kernel
and ramdisk details from struct boot_info.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
xen/arch/x86/setup.c | 25 ++++++++++++++++---------
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 0d2ee19998aa..c2bcddc50990 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -946,10 +946,8 @@ static unsigned int __init copy_bios_e820(struct e820entry
*map, unsigned int li
return n;
}
-static struct domain *__init create_dom0(const module_t *image,
- unsigned long headroom,
- module_t *initrd, const char *kextra,
- const char *loader)
+static struct domain *__init create_dom0(const struct boot_info *bi,
+ const char *kextra)
{
static char __initdata cmdline[MAX_GUEST_CMDLINE];
@@ -964,9 +962,21 @@ static struct domain *__init create_dom0(const module_t *image,
.misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0,
},
};
+ int headroom, mod_idx = first_boot_module_index(bi, BOOTMOD_RAMDISK);
I think headroom should stay unsigned long, which matches struct
boot_module.
With that
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Regards,
Jason
|
