[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 08/44] x86/boot: convert setup.c mod refs to early_mod
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 9 Oct 2024 10:31:53 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728484316; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=awfXqVkJzAmarYBRcC1fQ5JfBpTVEuKpG9SUMjCgYK0=; b=Fc7z+v9/XdL6rAukBJbuo7zS25gLw8rczIfMuRjuYhJOxQRFGKGjymSZoLYyZb85uWhSLYugbgIlTmQ17J6NA6HbzGkxIJ1L30LGZjXyVDqq7rtGmuUQAg9Rx1zK7/u5nbQ+M3YL2j/5vlDFOPLA9mjESZyKK2z5cttX76Ke2Jo=
- Arc-seal: i=1; a=rsa-sha256; t=1728484316; cv=none; d=zohomail.com; s=zohoarc; b=dwVCbYVRiENdwfEuwysfD+//SH243dtlYSrEE/IvZ88oBMH+GHVUF6vOzpT92qlk8eo6+7BkkABAgxVMKTGJ9wBlv7nopm7HgoJ4emi9636YfoJQNdQSEANTM83mDEpvwTl/Ghoei4lx351GzMk5d83+AzCpX/NMOeOiDAx3bHU=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 09 Oct 2024 14:32:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/9/24 10:29, Jan Beulich wrote:
On 09.10.2024 16:23, Daniel P. Smith wrote:
On 10/7/24 15:34, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1341,15 +1341,15 @@ void asmlinkage __init noreturn
__start_xen(unsigned long mbi_p)
set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT);
kexec_reserve_area();
- initial_images = mod;
+ initial_images = bi->mods[0].mod;
Isn't this wrong?
mod is the array of module_t * of *all* modules, but bi->mods[0].mod is
a single module_t *?
No it is not wrong:
bi->mods[0].mod == __va(mbi->mods_addr)[0]
Yet as it's seemingly wrong, a comment appears to be necessary.
That is fair, will add comment.
v/r,
dps
|
