[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 28/44] x86/boot: add cmdline to struct boot_module
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 9 Oct 2024 19:09:39 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728515384; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=40e/4V0FbjfFzC7HxpH/GJ6pMhmoWsInYs9/8mL35J0=; b=NLpdpVPdU2Vefu37uKbs9MMEJhDKtgWLU35hItpTgeHmpURZThh27dqQ4MOBeFBvNnVXCWUktbNRC91K5S+2e1P/uFthcHkiZS2m/eBb3g7j3VkM7yHzkJin3wHZlQrVkrUKOfrKxBWfXlTr+MeGoezbQP4n3PI+cAaCl/ZJIvg=
- Arc-seal: i=1; a=rsa-sha256; t=1728515384; cv=none; d=zohomail.com; s=zohoarc; b=adTPCsHosLUM/hNkU1lgMVhHjuWE8yyG121TG8TjJl+P07M1N5MEcPIBFwLTfApgVE5HVfdU6NDNiyFZ0VdYVYMQN32rnQXNKrrOYbufzBng1yRGZwpTP3mDxuC7akE3cmib4jH5HOlOEIsm9RW3ul8V5pBoC9FbeoxXpXhfyBY=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 09 Oct 2024 23:09:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/8/24 13:08, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
Add a char pointer field, cmdline, to struct boot_module to hold the
address
pointed to by the string field of struct mod. This removes the need to
use the
early_mod field to get to the dom0 kernel command line.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
xen/arch/x86/include/asm/bootinfo.h | 2 ++
xen/arch/x86/setup.c | 9 ++++++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/xen/arch/x86/include/asm/bootinfo.h
b/xen/arch/x86/include/asm/bootinfo.h
index 9ed260629012..3b6bfbe88770 100644
--- a/xen/arch/x86/include/asm/bootinfo.h
+++ b/xen/arch/x86/include/asm/bootinfo.h
@@ -38,6 +38,8 @@ struct boot_module {
#define BOOTMOD_FLAG_X86_RELOCATED (1U << 0)
#define BOOTMOD_FLAG_X86_CONSUMED (1U << 1)
+ const char *cmdline;
+
paddr_t start;
size_t size;
};
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index aed0837902c4..d5916e85f68e 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -312,6 +312,8 @@ static struct boot_info __init
*multiboot_fill_boot_info(unsigned long mbi_p)
{
bi->mods[i].mod = &mods[i];
+ bi->mods[i].cmdline = (char *)(paddr_t)mods[i].string;
+
bi->mods[i].start = (paddr_t)mods[i].mod_start;
bi->mods[i].size = mods[i].mod_end - mods[i].mod_start;
}
@@ -1000,10 +1002,11 @@ static struct domain *__init
create_dom0(struct boot_info *bi)
panic("Error creating d%uv0\n", domid);
/* Grab the DOM0 command line. */
- if ( image->mod->string || bi->kextra )
+ if ( image->cmdline || bi->kextra )
{
- if ( image->mod->string )
- safe_strcpy(cmdline, cmdline_cook(__va(image->mod->string),
+ if ( image->cmdline )
+ safe_strcpy(cmdline,
+ cmdline_cook(__va((unsigned
long)image->cmdline),
char * seems inappropriate if cmdline isn't usable as a string. Maybe
have cmdline as a paddr_t, or can __va() be used at assignment time?
Yah, char * was not the correct choice, paddr_t is more appropriate.
v/r,
dps
|
