Re: [PATCH] x86emul/test: drop Xeon Phi S/G prefetch special case

["Alejandro Vallejo" <alejandro.vallejo@xxxxxxxxx>]

On Wed Oct 16, 2024 at 8:46 AM BST, Jan Beulich wrote:
> Another leftover from the dropping of Xeon Phi support.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> Note: I'm deliberately not switching to use of the conditional operator,
> as the form as is resulting now is what we'll want for APX (which is
> where I noticed this small piece of dead logic).
>
> --- a/tools/tests/x86_emulator/evex-disp8.c
> +++ b/tools/tests/x86_emulator/evex-disp8.c
> @@ -911,10 +911,8 @@ static void test_one(const struct test *
>      n = test->scale == SC_vl ? vsz : esz;
>      if ( !sg )
>          n += vsz;
> -    else if ( !strstr(test->mnemonic, "pf") )
> -        n += esz;
>      else
> -        ++n;
> +        n += esz;

Just making sure. This is leftover from 85191cf32180("x86: drop Xeon Phi
support"), right? Dead code after the removal of the avx512pf group.

If so, that sounds good. But (not having looking at the general logic), how
come we go from ++n to "n += esz". It's all quite cryptic.

>  
>      for ( ; i < n; ++i )
>           if ( accessed[i] != (sg ? (vsz / esz) >> (test->opc & 1 & !evex.w)

Cheers,
Alejandro