Re: [PATCH] x86emul/test: correct loop body indentation in evex-disp8.c:test_one()

["Alejandro Vallejo" <alejandro.vallejo@xxxxxxxxx>]

On Wed Oct 16, 2024 at 11:15 AM BST, Jan Beulich wrote:
> On 16.10.2024 12:06, Alejandro Vallejo wrote:
> > On Wed Oct 16, 2024 at 8:45 AM BST, Jan Beulich wrote:
> >> For some reason I entirely consistently screwed these up.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > 
> >   Reviewed-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
>
> Thanks.
>
> > We should really give another push to the clang-format effort. This whole 
> > class
> > of mistakes would be a thing of the past.
>
> For issues like the one here it would depend on whether that would also be
> applied to (parts of) tool stack code. The plans, iirc, were mainly to cover
> the xen/ subtree.
>
> Jan

True, but AIUI that was merely an act of scope reduction for the sake of
getting something merged in a finite time frame. In an ideal world the whole
codebase would be covered, and I think this was a shared sentiment among those
in favour.

Cheers,
Alejandro