Xen project Mailing List

Re: [PATCH v6 07/44] x86/boot: move headroom to boot modules

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx

From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>

Date: Thu, 17 Oct 2024 20:19:29 -0400

Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729210774; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=pKs5rlu+UF0KVgzNhpCHFYB1Rd0E4htXrkx4KJCb8G8=; b=mTPm+PLKHEk8cah5NKL8nyKZHNVYfuhYVodMR9xtmPRLUX2lgw8NhKf80pxmCRMht3CslXkduRhVF2H9JOx4YvRSKz5HvxHAgYLD9z1Og8/RNGI9sOQPCYGqd5tsbEuKVnjd9rwMfQEwWFkLgu/P6NoD/0DgHCAHrSfrot7wRac=

Arc-seal: i=1; a=rsa-sha256; t=1729210774; cv=none; d=zohomail.com; s=zohoarc; b=ROmzkvP5hA532cjCBYpk7MhEhBEqxnSbYBh6jjD7dl7HALnMZV2fZUy0EZ5et63B7CWW/f19lqTTQDc9NFAxMPXNd3J5mXhazW5XU9saWm3JghqLjUhu9rH9TTfUzG7y7E9BxHgstj3kx3YtC73oWnh4xeItJ+0NLH77fnKNje0=

Cc: jason.andryuk@xxxxxxx, christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>

Delivery-date: Fri, 18 Oct 2024 00:19:45 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/17/24 17:39, Andrew Cooper wrote:

On 17/10/2024 6:02 pm, Daniel P. Smith wrote:

diff --git a/xen/arch/x86/include/asm/bootinfo.h 
b/xen/arch/x86/include/asm/bootinfo.h
index d19473d8941e..5fe4f1387d03 100644
--- a/xen/arch/x86/include/asm/bootinfo.h
+++ b/xen/arch/x86/include/asm/bootinfo.h
@@ -17,6 +17,19 @@
  struct boot_module {
      /* Transitionary only */
      module_t *mod;


Blank line here.

I know it falls back out later, but it's very important for legibility
to be able to tell at a glance which comment belongs to which item.

Ack. v/r, dps

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.