[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 11/44] x86/boot: add start and size fields to struct boot_module
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Sat, 19 Oct 2024 07:32:44 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729337568; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=5S4ocbMRN/ZDTrHRIpLShwguvEXp7SmgKv9cGlo+DFI=; b=OiWGmtOHZzjAaDsLqO2XeeLPOPbfwb+d6s1eZZER9J009aGnVayaSHHYDd3NBi9vh6CloSJwbsu1pz2cA2xhQGvnC64e5f779bONQhlSFvmYSzLdyDJC51/2B1igCJXbp7J7QPGyJ0Nd+rlHXjEGvdw57pkjIJK2XYfAOlA+OQI=
- Arc-seal: i=1; a=rsa-sha256; t=1729337568; cv=none; d=zohomail.com; s=zohoarc; b=NSAfYFcjdk/xpSZifwfm29T45632m4wEKe5rqCeUlvb1z49jOpx39v5s5sdjzfM1rrtGCx3FLNV2qfBDVTRokqQXvJpn416PbQ/IvA2OkjcxfS4LAPbwgiu/7QQV0BVEUluAWbPkZ1lYiFS6l42fkJWIekoESuJIC+qZIQEJ0iQ=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Sat, 19 Oct 2024 11:33:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/17/24 19:12, Jason Andryuk wrote:
On 2024-10-17 13:02, Daniel P. Smith wrote:
This commit introduces the start and size fields to struct boot_module
and
assigns their value during boot_info construction.
The EFI entry point special cased itself, and pre-converted mod_start and
mod_end to mfn and size respectively. This required an additional test
in the coversion loop to not convert mod_start and mod_end when the
conversion
conversion
Ack.
was done for both the multiboot and PVH boot entry points. To simplify
the
logic populating the start and size fields, the EFI module population
logic
was coverted to using start and end addresses.
converted
Ack.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
with that
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Thank you but will hold off since Andy has asked this be split and changed.
EFI now gains the alignment check, but beforehand it was just silently
truncating. Seems better to check :)
My thinking as well.
v/r,
dps
|
