[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 13/44] x86/boot: transition relocation calculations to struct boot_module
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Sat, 19 Oct 2024 08:02:23 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729339345; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=iRk+UeqORKfqBassxklkpgtIy64S1iDTrldwYgFsmTM=; b=ZtqKtO5xeH5rFd4DFT8LMjoZNPaWgX0HZXPP3I5eYUjgkog+oXHFYnOpFMrvEkJeA0QSbZnJ4HSRiUqd6IdNi/MDVpSKPnc/DqcrYu5PuGPAPmcegPrZ4cGUgPOJlqSQmQoc69C/MbA5663xg/aqkPXQyfHqDmJA06td/KnHl80=
- Arc-seal: i=1; a=rsa-sha256; t=1729339345; cv=none; d=zohomail.com; s=zohoarc; b=mgESEPhQeGKFaTKgVEZDHqRI4dbH7bB0TX05EcNLAYjbdEa/JtUg1uVmZpaY3AQ/vbkNYgD2ogoIKfaC8iH/w3lJXtN4QWOa1PnyLgJ6uFeG7bRzcXciLaJOy7+H7OhTmoHaJkWwTcT2EhaSamO3GVh36kX5cn9wgnvZSM8SdjM=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Jason Andryuk <jason.andryuk@xxxxxxx>
- Delivery-date: Sat, 19 Oct 2024 12:02:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/18/24 02:39, Jan Beulich wrote:
On 18.10.2024 02:42, Jason Andryuk wrote:
On 2024-10-17 13:02, Daniel P. Smith wrote:
@@ -1686,12 +1682,12 @@ void asmlinkage __init noreturn __start_xen(unsigned
long mbi_p)
for ( i = 0; i < bi->nr_modules; ++i )
{
- set_pdx_range(bi->mods[i].mod->mod_start,
- bi->mods[i].mod->mod_start +
- PFN_UP(bi->mods[i].mod->mod_end));
- map_pages_to_xen((unsigned
long)mfn_to_virt(bi->mods[i].mod->mod_start),
- _mfn(bi->mods[i].mod->mod_start),
- PFN_UP(bi->mods[i].mod->mod_end), PAGE_HYPERVISOR);
+ set_pdx_range(paddr_to_pfn(bi->mods[i].start),
+ paddr_to_pfn(bi->mods[i].start) +
+ PFN_UP(bi->mods[i].size));
+ map_pages_to_xen((unsigned long)maddr_to_virt(bi->mods[i].start),
+ maddr_to_mfn(bi->mods[i].start),
+ PFN_UP(bi->mods[i].size), PAGE_HYPERVISOR);
I would vertically align all the parameters inside the (.
At the very least the two successive calls want formatting the same way.
Plus imo the presented formatting of map_pages_to_xen() isn't "legal"
anyway, it ought to be
map_pages_to_xen(
(unsigned long)maddr_to_virt(bi->mods[i].start),
maddr_to_mfn(bi->mods[i].start),
PFN_UP(bi->mods[i].size), PAGE_HYPERVISOR);
Agreed, will change to the above.
v/r,
dps
|
