[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/boot: Fix PVH boot following the start of the MBI->BI conversion
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Sat, 19 Oct 2024 14:23:52 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729362235; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=SHoNmuO0gYmDxQNpXWyCwOI+zewpEv3IPGRCkzcH7YU=; b=mMy0gKtMXQJ04XONQvrkIoq3+NCBZx7qCk2Gh4sh+z0wlr6/tMAF1zUMoJx4Y7wnmWMu/BE7zpfDHyqMPm3kKMWtnMtxH9FJbwNwayW05io1Mbp7mSlDXB3lHJ1qsl43Y6MbuW6lSLgQUTFJ1sW02eZT5buCM72tQNmGxuJWSMs=
- Arc-seal: i=1; a=rsa-sha256; t=1729362235; cv=none; d=zohomail.com; s=zohoarc; b=N84psd4OuWCRHbPXfMqew9IriduK9qEoF8SMbOEk9jt6mnPcPoEQL3Nw35Lbp7yYJ4+u6k2sclOO/MEBQLVWHiUFMpwFOsYnRASyINbPWZX33LCT9khjpmYrWZlDrIpZova8I2sHaCLkm7FUuIBONZvSI7N+2NzZW8TjxeirDn4=
- Cc: Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Sat, 19 Oct 2024 18:24:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/19/24 14:20, Andrew Cooper wrote:
pvh_init() sets up the mbi pointer, but leaves mbi_p at 0. This isn't
compatbile with multiboot_fill_boot_info() starting from the physical address,
in order to remove the use of the mbi pointer.
Fixes: 038826b61e85 ("x86/boot: move x86 boot module counting into a new boot_info
struct")
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
This is a testiment to how tangled the boot code really is.
---
xen/arch/x86/setup.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 6746ed8cced6..bfede5064e8c 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1048,6 +1048,7 @@ void asmlinkage __init noreturn __start_xen(unsigned long
mbi_p)
{
ASSERT(mbi_p == 0);
pvh_init(&mbi, &mod);
+ mbi_p = __pa(mbi);
}
else
{
base-commit: e9f227685e7204cb2293576ee5b745b828cb3cd7
Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
|
