[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] x86/boot: Convert move_memory() to use bootstrap_map_addr()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Tue, 22 Oct 2024 20:12:17 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729642345; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Vxb4Llf6gvL7ZFvjwjCMx+vj0rU5C4YZsyTw95Kv9q8=; b=QiUXRGCDiS940u3305JLcLrIE5bY5YXt/mKVLR7Lmw4jVSiPFB1J64/8C/ApbKAQos8r34nK/HN64uulaMFaALmKtoCPuyQe8HpkO3LC/DIwRukCpW2rv10Jk6hUSUE7ViARoBXIuGvBamVSdj6F6wK4oCGY2sPj0EqoJUi2yGQ=
- Arc-seal: i=1; a=rsa-sha256; t=1729642345; cv=none; d=zohomail.com; s=zohoarc; b=laeEHhkjPLgJrZZhUMVzsnHW8L59Cyj23ipLefSOFQ2o1T4Sq9ndmeV4X/mbP+8xtDVdfXKlbxHsOOBTtmBVW0DGnmnxpJ72xqeX4bFyky59nLhir+gQ+vKBYQCCbvG0Hq+U0BwCj6ExDQ1xZVXl/Evy6xR/0w6t+IzNP1qwrIE=
- Cc: Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 23 Oct 2024 00:12:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/22/24 18:39, Andrew Cooper wrote:
move_memory() is very complicated, and buggy. In order to fix the latter, we
have to address the former.
Given prior cleanup, bootstrap_map() is now implemented in terms of
bootstrap_map_addr(), meaining that it is counterproductive to plumb the
mapping through module_t.
Delete mod, and introduce two same-sized/named fields. At this point in boot,
neither fields have their named purpose, so indicate the purpose in comments.
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
|