[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] x86/boot: Explain how discard_initial_images() works


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Thu, 24 Oct 2024 12:42:06 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729788154; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=x4/TnSsW7+E4msXP5ig1Bx7CXFMPKNACg6DP3jRDBzQ=; b=emoyXk+oh/n+bl27CMVS92p3f0/yJGMGdT4BIsB1gR7mE+jVrzcehcycXSavb3BLCv/0vVRaKa2ZsBizLZk0Xoit0W68DYCHQLzKsoQlNCYb4Pp5koslzg5P7FT5cWPSzW72k3Q/d2O010FpL1PyRThCeITMBlQowMPlpNvxml0=
  • Arc-seal: i=1; a=rsa-sha256; t=1729788154; cv=none; d=zohomail.com; s=zohoarc; b=W/bLTcUwFh7F83ztvf7NyyesSa0xzdByH6ErcUj9cKuOzWXt5yrhCmD0rtCWn74/8YyZMzFpnlYzUYHuZCqz4o8KM5/B61Dqvcx8gMuAjA0dSFJ4HaNVxALuMtK8SOcasMoT2094MAgHI4dkg8T5xN3uJboCd5qwehN22wTdgSE=
  • Cc: Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 24 Oct 2024 16:42:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/24/24 12:03, Andrew Cooper wrote:
discard_initial_images() only works because init_domheap_pages() with ps==pe
is a no-op.

In dom0_construct(), explaining the significance of setting the initrd length
to 0, and put an explicit check in discard_initial_images().

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Daniel Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.