[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/6] xen/arm: Skip initializing the BSS section when it is empty
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 28 Oct 2024 14:45:05 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9oX26I12b3G2+XM0slrE6A4HAe5z+uCuHuHK9kdiy9g=; b=Yxl11BhRaEiMWS0J2uMgXf+AgJ2rkQ4z+YYolk0Proqn6+JL7K8OHvuqMR3Enk4JGMw7OcTaUQGzhxJ/szZv9yeYM9yLsR8zPEpNpM/Yaliqru1lBTG7wxdrPwsEl876JDSPTSk3OfLfTN1KVrqxrtWv7T099FQWfDnVxFFoBXRLfQA9flfvYY8to0/YqQUe53ClmmWLtMDsSPuNsgHaUGH566nQkX57wI/RR6NFWmOzx96ZJmTXX9eyJIyBgdsXFBMBt+fd6wcZXTS3tTIS7pbCgMGfeBnhmymoVe4KoqNJZslpW6/awCKiCqoCPr277sRn/LC+s96y9Vaz+7aDXg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9oX26I12b3G2+XM0slrE6A4HAe5z+uCuHuHK9kdiy9g=; b=WzmHnsHJeW3gf7SvKXKuXzqCCq55+Zwamz/n6vIvryi3yOLMsoXRxI3esS3C80aOzEcNZuBJnv7pkKeEjucHThlHytucI9OmZaaSiIKmnwt3g9wIz0yqFrAO0i94/2G9Ja3jc7tVw18wOJrpgD2M0lNn5KPaeFeiT1L8/uFrLPOFKAimx8Nkw9p5+CzSKTbCpogR3lk8ejW8KTPQLZR3OEVwAZSzf10O5ttr6d/2JJqs7gYxSoTzG4nFoC6bde58OyQdefJN/nYSenpFi/eb/3loY0yclukd8/fkGAj7jwaNfoSF2p2KS2UnopUctLVdLO2MifW4fxbsUwUZJpzAPQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=is1I1iZiGskLXmFgvpqVBFaS0zkTcHRVOI14divC7uoQhXNL+gHSYPF5mJtZ4ykFUN6zOm4fTEvZXYw+92kZPAGnml9IVC3TfVK5D08udLxgMR6+Tn7hT6+653MIELhfgHJSoVMsDMofyX53YpG5w2og40SLAc0p/71zCuHK07EgdcG8G5GXyc454a04bzmI6acpaOK/K2L9cKRytsmC4IFxlDofOcC3HchOmS/YxYMK42Jn/4hzHc3DuBJh3jeGmo7V6CbULlK0YIZ7Z73iXycqGI2+pAIp3aYph4CeYJiwecFEJ6+fEpNQsrkBX6hEL6oh4UipanwExMWsLmL/3g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ciQRQyymZ0XHmnBnkwjLITVqHs8DUp5AHB6yabuKR3b2rfkBf/4SUj+xrMIgkzSmIv7mhx5O5Zw5cx0hr4xqN7fNNaRhpnxcMsvoch7baD6ieWgNim1PM/aQ7EOQ1r+me6bYGRG200o6vTgRo6+qVqxcpVfMRQsCWw7YsuD3TItnUHJzK2B0640ZJWomeL60SkXOokMmMflr2XWVRICyyDBbV5BHaFVietSjcJ6PAdLqoHvv4S7QxycQ9OcfjpFAXiAIIwQkOZbS+Zy8FeI5D3youWTmrJMCTe0c9F9piAex7qwWK4fR1lJFGoV+sRwgQGuo0+Vpizn4QWfkj7R08g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 28 Oct 2024 14:45:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbKTdm6ZaHmASNrkyDueCee1TzurKcPXmA
- Thread-topic: [PATCH v4 1/6] xen/arm: Skip initializing the BSS section when it is empty
Hi Ayan,
> On 28 Oct 2024, at 12:45, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
>
> If the BSS section is empty, then the function should return.
> If one does not check whether the BSS section is empty or not, then there is a
> risk of writing 0s outside of BSS section (which may contain critical data).
>
> Fixes: dac84b66cc9a ("xen: arm64: initial build + config changes, start of
> day code")
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> —
Looks good to me
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
