[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] CI: Fix cppcheck parallel build more
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 31 Oct 2024 17:11:09 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2pPED0NWh0OPt5eCHNklhntRuGPQ6Ip4PqmiAe0q79U=; b=FqLPp3yTu8H3hgvUF3NF0XMrcZgJhYc5o2FF8lUIZJITrTQve6qicMggrpYBx8qCo6DhCzMnH4oRPQqQn2szte5Pt8w7xhucv93AAwshM64eSOMtfONrKuCCOMv9TthIw11vcT3boLrclgEofSnY8+xXb3oSs+FayfnJw6oWUWbmOXiIV9IdRaAhMv8kR+VX7VJYlK0PEm0biXPzxamES12RAD7A/stB1f/FpW6fIKprhByLTG3O2SNQigkcJ6dDwrMvJA6+m4nDtV/eAb3xmnYXs6pukCF/x5yrhZ3JOelkbsVd5kGA8ABoFLUA9vQJtcgm9lodL9WKR0MKEdSmpw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2pPED0NWh0OPt5eCHNklhntRuGPQ6Ip4PqmiAe0q79U=; b=oGbRag1DMplaav3OcSavHJdplw6q/swojX4hMbvuCTZyp3KKk4M9AeFpNRzUMIrOsK2FAHiF2aK1YzW10lrkZZU3Z4DJqzbF2Mz4gwpXKx/UeggVPTduudwrnn4pNV7VIz53JrIcRlUyS0hT09lfaz0+D1A7o6oOj6/I7V+QUz1IbMWn/Jv9+AnKMmcpGu6lYDWYop1dtBEOz5zyK0CjoCUz6QYrttv6wTI0EkkK+w1RxQ07W6zrdBP36Fb0M8tcwFE4RpLXl1838OtIEfPzFYQ5E/gRx1fjr2HPk7Xktwl/0KIvgZq/frVWU9Dn00HmsJt2O0QYn0p1Lqf3pkdd6A==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=H8YNunS/HbnTqD+ZIP9di+7dGnRwPcBbn6C06pUMQ+MnL7MEW6MFvqxDFkj/+0/aIEp23I5ViJbIvQLhKgkeiK+k6lyYR8Ac5ItYLeVLiarstP4+R01mYJpseckKLeoM7pBXFnkwVL+w4eOuHzvR371k7J5T5zFNAhfEI2lC3/bNZdh7rk+6bEZenecDrrqOR62cOD4pb5+8zMg8986hFzNsCNlfWY+QExwOObFrpoVxKo1v/wqRzh51NJb1hZ8X7VTQ51xT0PKoF38ZD5pOiNLB2RkPR4uEg5p91M3bnSvMqDzWHu6rHG3yHR7glK1yhwvjNV+PNZh7K59akRM6eQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tkxTA5BjVMzSHrnDzK5Bl2iDQMdUAuxjXE1cmXLgKPXY9MYAvnvBQeH3mpZi7bTL6lX13AYCs58N9TlWAN2PVDs7+CWGnjr1AqalIlKawFLkW/ZMxdlAg5vt4e3Ag5lLYKvPcYLUnppK5cvpE/m61Xm+1MguXhmgjoWISMKA2uSao6RAW25TtZM2XEV63qqbz6J87bVanQ+vIotqvOlvDlX4tfbnPscj14j9RSVBOD0V6yTPDW9/t9dwE5WawV5AfN0w3p3Ura2H4GE3zzCg68+MmRN5R0Jhfs6J0ju68jgIX4ZPkWUV1qnR4yxprM9x+kKTb5GFTvg96Z7kQmPN1g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Thu, 31 Oct 2024 17:11:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbK7WmFiXt1BnVNkmuAcmSAaPqQ7KhGEkA
- Thread-topic: [PATCH] CI: Fix cppcheck parallel build more
Hi Andrew,
> On 31 Oct 2024, at 16:55, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> A recent cppcheck run was found to fail:
>
> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/8237167472
>
> with:
>
> "type mismatch! call is<type>() before get<type>()" && is<std::string>()
> make[3]: *** [arch/x86/boot/Makefile:28:
> arch/x86/boot/reloc-trampoline.32.o] Error 1
>
> This turns out to be a parallel build issue, combined with a recent change to
> x86. Notably, we now have a case where we build both:
>
> CC arch/x86/boot/reloc-trampoline.32.o
> CC arch/x86/boot/reloc-trampoline.o
>
> from the same original C file, and cppcheck uses the source C file as the key
> for generating it's intermediate files.
>
> Switch cppcheck to use the object file as the unique key instead.
>
> Fixes: 45bfff651173 ("xen/misra: xen-analysis.py: fix parallel analysis
> Cppcheck errors")
> Fixes: db8acf31f96b ("x86/boot: Reuse code to relocate trampoline")
> Suggested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> —
Looks good to me!
I’ve also checked with and without the patch and I can’t see any regression in
terms of cppcheck
issues report.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
