[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/10] x86/ucode: Use bootstrap_unmap() in early_microcode_load()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Sat, 2 Nov 2024 12:51:40 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1730566303; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=VOL5fOcacaBF/uk3UOY/VDMzifJ5yz8EJ2MI1F0MqEE=; b=LZCAhDRNSTZjWpBzdw9vPlp1GSl2M9Gdd1aSCjYvp2Z00q48JxN76IV1H60uHMCk1fgSN/yD6y7MbOqzEAhLfsV62X25q6MZunojnECUlVVTwKzmmT/alkqTOXoQw2PjcWSoJA5HoJVo3F3jcNW5s14cIF23jr/8imFCsqE/4ek=
- Arc-seal: i=1; a=rsa-sha256; t=1730566303; cv=none; d=zohomail.com; s=zohoarc; b=CxoNgkRl/esMCHFaUPs6iTdQ42HFYo4aJizuEotBnBYpaIVA4NoYt1jFqK8LULVtyaN16mQVri3LkkcpvDqKOixBAlBQ+e9eHsDm04V5bx5fjAvPchpw+LBi3ossoER58IsUfXGsXFeWIB2+dwq9dEVCHtOtF3SxkuusvGif4tc=
- Cc: Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Sat, 02 Nov 2024 16:51:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/28/24 05:18, Andrew Cooper wrote:
If bootstrap_map() has provided a mapping, we must free it when done. Failing
to do so may cause a spurious failure for unrelated logic later.
Inserting a bootstrap_unmap() here does not break the use of ucode_{blob,mod}
any more than they already are.
Add a printk noting when we didn't find a microcode patch. It's at debug
level, because this is the expected case on AMD Client systems, and SDPs, but
for people trying to figure out why microcode loading isn't work, it might be
helpful.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
|
