Re: [PATCH] xen/Kconfig: livepatch-build-tools requires debug information

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Nov 07, 2024 at 09:21:26AM +0000, Andrew Cooper wrote:
> On 07/11/2024 8:49 am, Roger Pau Monne wrote:
> > The tools infrastructure used to build livepatches for Xen
> > (livepatch-build-tools) consumes some DWARF debug information present in
> > xen-syms to generate a livepatch (see livepatch-build script usage of 
> > readelf
> > -wi).
> >
> > The current Kconfig defaults however will enable LIVEPATCH without 
> > DEBUG_INFO
> > on release builds, thus providing a default Kconfig selection that's not
> > suitable for livepatch-build-tools even when LIVEPATCH support is enabled,
> > because it's missing the DWARF debug section.
> >
> > Fix by forcing the selection of DEBUG_INFO from LIVEPATCH.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> Oops, yes.
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Fixes tag ?

Was borderline on adding one, but wasn't sure since it's strictly
livepatch-build-tools that requires the DWARF data, but custom made
livepatches (like the examples in tests) do not require such
information.

Possibly:

Fixes: 11ff40fa7bb5 ('xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op')

Which is the commit that originally introduced the CONFIG_XSPLICE option.

Thanks, Roger.