[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/12] x86/boot: introduce boot domain
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Fri, 8 Nov 2024 14:20:19 -0500
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1731093624; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=3SwoarSDdh+gZemX9amQd8J1gBrNVFneYdXOGW7iHo0=; b=h7cpdBGb2jIfYo2BOheRKmfO6Cl/UCCxazSRoIZT1k7G1JzWI3c8J7ZWn/siQa9unk/wUGCQhXECTzdkmhhYYFv1tFMqjEOgf8CG4+tHg/bt9+kY5B/CJdIXMYvxBC6VqZzqamZj2NW27uwF5J4Ko72sJrjvcDvnQqa+cU0aDEs=
- Arc-seal: i=1; a=rsa-sha256; t=1731093624; cv=none; d=zohomail.com; s=zohoarc; b=MzslziarQb9QrX6gxokLde2b+vAS4Lv0YD7IIxg5VER9iCYBV1nZQZXpS4Lqyb3p/UKt8X0ojI3Lwpyv+LS2PLMw8y2IjmFIpr8FvfoyzrmtuJdd50vDz9Hszm0zuFs4iL6t34Myq25+6rVH8wG1qnXfGLUGlJMM7rWhrH89gbg=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 08 Nov 2024 19:20:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/7/24 15:58, Jason Andryuk wrote:
On 2024-11-02 13:25, Daniel P. Smith wrote:
To begin moving toward allowing the hypervisor to construct more than one
domain at boot, a container is needed for a domain's build information.
Introduce a new header, <xen/asm/bootdomain.h>, that contains the initial
struct boot_domain that encapsulate the build information for a domain.
Add a kernel and ramdisk boot module reference along with a struct domain
reference to the new struct boot_domain. This allows a struct boot_domain
reference to be the only parameter necessary to pass down through the
domain
construction call chain.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
Changes since v7
- collapsed the incremental changes to the call chain into this commit
---
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 18b93d6a272a..6e25a9f726c7 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1026,11 +1019,11 @@ static struct domain *__init
create_dom0(struct boot_info *bi)
panic("Error creating d%uv0\n", domid);
/* Grab the DOM0 command line. */
- if ( image->cmdline_pa || bi->kextra )
+ if ( bd->kernel->cmdline_pa || bi->kextra )
{
- if ( image->cmdline_pa )
- safe_strcpy(
- cmdline, cmdline_cook(__va(image->cmdline_pa), bi-
>loader));
+ if ( bd->kernel->cmdline_pa )
+ safe_strcpy(cmdline, cmdline_cook(__va(bd->kernel-
>cmdline_pa),
+ bi->loader));
I'd indent bi->loader so it lines up with __va, since bi->loader is the
second argument to cmdline_cook().
Ack.
With that:
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Thanks,
v/r,
dps
|
