Re: [PATCH v1] drivers/char: move dt_uart_init() to dt-uart.c

[oleksii.kurochko@xxxxxxxxx]

Hi Julien,

On Mon, 2024-11-11 at 10:24 +0000, Julien Grall wrote:
> Hi Oleksii,
> 
> On 08/11/2024 14:56, Oleksii Kurochko wrote:
> > The `dt_uart_init()` functions is relocated to a new file `dt-
> > uart.c` to allow
> > for reuse across architectures that utilize the device tree to
> > describe hardware
> > components.
> > 
> > RISC-V is going to follow the same approach to UART initialization,
> > which
> > includes checking for the presence of `dtuart` in the console
> > string or verifying
> > the `stdout-path` property in the `/chosen` node, followed by
> > searching for the UART
> > node and calling `device_init()` for UART setup.
> > 
> > Add `xen/drivers/char/dt-uart.c` to the ARM ARCHITECTURE section in
> > the MAINTAINERS
> > file, as ARM maintainers are best suited to maintain this code.
> > 
> > No functional change.
> > 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > ---
> >   MAINTAINERS                 |  1 +
> >   xen/drivers/char/Makefile   |  1 +
> >   xen/drivers/char/arm-uart.c | 80 -------------------------------
> 
> The only thing left in arm-uart.c is the ACPI initialize. I guess at
> the 
> some point this will be needed for other architectures. I think it
> would 
> be more suitable if the file is renamed, maybe uart-init.c?
It seems like you are right and it would be better just to rename the
file. ( I checked Linux kernel source code and RISC-V there also is
using SPCR table to store the configuration of console.

I will send a new patch version.


Thanks!

~ Oleksii