[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 22/22] jiffies: Define secs_to_jiffies()
- To: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxx>, Julia Lawall <Julia.Lawall@xxxxxxxx>, Nicolas Palix <nicolas.palix@xxxxxxx>, Daniel Mack <daniel@xxxxxxxxxx>, Haojian Zhuang <haojian.zhuang@xxxxxxxxx>, Robert Jarzmik <robert.jarzmik@xxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, Ofir Bitton <obitton@xxxxxxxxx>, Oded Gabbay <ogabbay@xxxxxxxxxx>, Lucas De Marchi <lucas.demarchi@xxxxxxxxx>, Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Thomas Zimmermann <tzimmermann@xxxxxxx>, David Airlie <airlied@xxxxxxxxx>, Simona Vetter <simona@xxxxxxxx>, Jeroen de Borst <jeroendb@xxxxxxxxxx>, Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>, Shailend Chand <shailend@xxxxxxxxxx>, Andrew Lunn <andrew+netdev@xxxxxxx>, James Smart <james.smart@xxxxxxxxxxxx>, Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxx>, Jeff Johnson <jjohnson@xxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>, Marcel Holtmann <marcel@xxxxxxxxxxxx>, Johan Hedberg <johan.hedberg@xxxxxxxxx>, Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>, Ray Jui <rjui@xxxxxxxxxxxx>, Scott Branden <sbranden@xxxxxxxxxxxx>, Broadcom internal kernel review list <bcm-kernel-feedback-list@xxxxxxxxxxxx>, Xiubo Li <xiubli@xxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Jiri Kosina <jikos@xxxxxxxxxx>, Miroslav Benes <mbenes@xxxxxxx>, Petr Mladek <pmladek@xxxxxxxx>, Joe Lawrence <joe.lawrence@xxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Lucas Stach <l.stach@xxxxxxxxxxxxxx>, Russell King <linux+etnaviv@xxxxxxxxxxxxxxx>, Christian Gmeiner <christian.gmeiner@xxxxxxxxx>, Louis Peens <louis.peens@xxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Naveen N Rao <naveen@xxxxxxxxxx>, Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>
- From: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
- Date: Fri, 15 Nov 2024 13:30:34 -0800
- Cc: <netfilter-devel@xxxxxxxxxxxxxxx>, <coreteam@xxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <cocci@xxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <linux-s390@xxxxxxxxxxxxxxx>, <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, <intel-xe@xxxxxxxxxxxxxxxxxxxxx>, <linux-scsi@xxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <linux-block@xxxxxxxxxxxxxxx>, <linux-wireless@xxxxxxxxxxxxxxx>, <ath11k@xxxxxxxxxxxxxxxxxxx>, <linux-mm@xxxxxxxxx>, <linux-bluetooth@xxxxxxxxxxxxxxx>, <linux-staging@xxxxxxxxxxxxxxx>, <linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx>, <ceph-devel@xxxxxxxxxxxxxxx>, <live-patching@xxxxxxxxxxxxxxx>, <linux-sound@xxxxxxxxxxxxxxx>, <etnaviv@xxxxxxxxxxxxxxxxxxxxx>, <oss-drivers@xxxxxxxxxxxx>, <linuxppc-dev@xxxxxxxxxxxxxxxx>, Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx>, Michael Kelley <mhklinux@xxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
- Delivery-date: Fri, 15 Nov 2024 21:31:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/15/2024 1:22 PM, Easwar Hariharan wrote:
> secs_to_jiffies() is defined in hci_event.c and cannot be reused by
> other call sites. Hoist it into the core code to allow conversion of the
> ~1150 usages of msecs_to_jiffies() that either:
>
> - use a multiplier value of 1000 or equivalently MSEC_PER_SEC, or
> - have timeouts that are denominated in seconds (i.e. end in 000)
>
> It's implemented as a macro to allow usage in static initializers.
>
> This will also allow conversion of yet more sites that use (sec * HZ)
> directly, and improve their readability.
>
> Suggested-by: Michael Kelley <mhklinux@xxxxxxxxxxx>
> Signed-off-by: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
> Link:
> https://lore.kernel.org/all/20241030-open-coded-timeouts-v3-1-9ba123facf88@xxxxxxxxxxxxxxxxxxx
your signed-off-by should be last.
and you have a patch ordering problem since this patch must come before all
the patches that use secs_to_jiffies(), otherwise this series cannot be bisected
|