Re: [PATCH v2 01/21] netfilter: conntrack: Cleanup timeout definitions

[Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>]

Hi Easwar,

On Fri, 15 Nov 2024 21:26:18 +0000 Easwar Hariharan 
<eahariha@xxxxxxxxxxxxxxxxxxx> wrote:
>
>  static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = {
> -     [SCTP_CONNTRACK_CLOSED]                 = 10 SECS,
> -     [SCTP_CONNTRACK_COOKIE_WAIT]            = 3 SECS,
> -     [SCTP_CONNTRACK_COOKIE_ECHOED]          = 3 SECS,
> -     [SCTP_CONNTRACK_ESTABLISHED]            = 210 SECS,
> -     [SCTP_CONNTRACK_SHUTDOWN_SENT]          = 3 SECS,
> -     [SCTP_CONNTRACK_SHUTDOWN_RECD]          = 3 SECS,
> -     [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT]      = 3 SECS,
> -     [SCTP_CONNTRACK_HEARTBEAT_SENT]         = 30 SECS,
> +     [SCTP_CONNTRACK_CLOSED]                 = secs_to_jiffies(10),
> +     [SCTP_CONNTRACK_COOKIE_WAIT]            = secs_to_jiffies(3),
> +     [SCTP_CONNTRACK_COOKIE_ECHOED]          = secs_to_jiffies(3),
> +     [SCTP_CONNTRACK_ESTABLISHED]            = secs_to_jiffies(210),
> +     [SCTP_CONNTRACK_SHUTDOWN_SENT]          = secs_to_jiffies(3),
> +     [SCTP_CONNTRACK_SHUTDOWN_RECD]          = secs_to_jiffies(3),
> +     [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT]      = secs_to_jiffies(3),
> +     [SCTP_CONNTRACK_HEARTBEAT_SENT]         = secs_to_jiffies(3),

You have changed this last timeout from 30 seconds to 3 (presumably
just a copy and paste error).

-- 
Cheers,
Stephen Rothwell

Attachment: pgp4gsYVV3e9C.pgp
Description: OpenPGP digital signature