Re: [PATCH v2 21/21] nfp: Convert timeouts to secs_to_jiffies()

[Christophe Leroy <christophe.leroy@xxxxxxxxxx>]

Le 15/11/2024 à 22:26, Easwar Hariharan a écrit :
> [Vous ne recevez pas souvent de courriers de eahariha@xxxxxxxxxxxxxxxxxxx. Découvrez 
> pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
As you plan to get those merged independant in each tree, I guess it 
should be sent to netdev list targetting net-next tree in the subject 
line as per netdev rules.


> Changes made with the following Coccinelle rules:
>
> @@ constant C; @@
>
> - msecs_to_jiffies(C * 1000)
> + secs_to_jiffies(C)
>
> @@ constant C; @@
>
> - msecs_to_jiffies(C * MSEC_PER_SEC)
> + secs_to_jiffies(C)
>
> Signed-off-by: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>
> ---
>   drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c 
> b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 
> 6e0929af0f725b2b3855c69bbe894e6626c566b3..6925ad985fc9e2d5641feea41ff277107a8dee9c
>  100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -2779,7 +2779,7 @@ static void nfp_net_netdev_init(struct nfp_net *nn)
>                  break;
>          }
>
> -       netdev->watchdog_timeo = msecs_to_jiffies(5 * 1000);
> +       netdev->watchdog_timeo = secs_to_jiffies(5);
>
>          /* MTU range: 68 - hw-specific max */
>          netdev->min_mtu = ETH_MIN_MTU;
>
> --
> 2.34.1