[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] misra: increase identifiers length to 64



On Mon, 18 Nov 2024, Nicola Vetrini wrote:
> On 2024-11-18 09:58, Jan Beulich wrote:
> > On 16.11.2024 01:23, Stefano Stabellini wrote:
> > > Currently the identifiers characters limit is arbitrarily set to 40. It
> > > causes a few violations as we have some identifiers longer than 40.
> > > 
> > > Increase the limit to another rather arbitrary limit of 64. Thanks to
> > > this change, we remove a few violations, getting us one step closer to
> > > marking Rules 5.2 and 5.4 as clean.
> > > 
> > > Also update the ECLAIR config that was actually set to 63 as character
> > > limit.
> > 
> > What I don't really understand: With the Eclair config already having said
> > 63, how come we did see patches aiming at dealing with the limit being just
> > 40? IOW - how would those (supposed) issue even have been spotted.
> > 
> 
> Hi Jan,
> 
> the issue was spotted by Andrew, and therefore we made the patches to align
> the configuration with the limits chosen by the project, which makes those
> violations appear. It is also possibile to do it the other way around (align
> the rst with the ECLAIR configuration), which spares the need for additional
> deviations.
> 
> In that case, I agree that 63 is better than 64.

Actually, I was wondering the same question as Jan when writing this
patch. Thanks Jan for asking explicitly and thanks Nicola for
clarifying. I'll resend using 63.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.