[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] bootfdt: Unify early printing of memory ranges endpoints
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Tue, 19 Nov 2024 14:37:55 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.12) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/6jS/mGGbv7bHeCzXkQuZNpDzTDa2a0olbskBDw3l0c=; b=xDZzjRxJU10o7vbAHF8orkJNaXHK7EregMqesWJ4d9Exc2SIUVnCaflB07iIGZ2O31HY5kOgoZIdo0B1l2bMhvNN4qAj4UionrUMkRWTeoUKu2JhCjNUTs26k1q3TjkHqewWltm/mDVNE7ePbgvc3dJ+NbPaMF4wZoddhX3CPSnbQNL1LjFq/gpAnjOvTGRLB4WZy6uqgIX9Ro6BLGXVskxyfrmVwdijDQobyQfo93+y/6k5p3MrI0SFn+XUpSptJCqKEdpJ9l4hsFg6TiB68ywYzTiwZU0JMW7I/kE2tmx7QPOfTNVuzacd5sEOL7oXxTMyaZ3LS216HK63E/slEw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C5JU4ooAE6dMvNiJ47w+fkfKs6xAGLGtvQNIQ7muodu5koP41dfNhwGYV39LgWo4TgQazOaCBqG3/FGMx8ny1YArp6a9rZJdSgZwtcJv0gWVMG8gpyZ3P+s2ofI4BhBMgXILdpVCnPGfiXjSFiPOHZ25xNOIgYRQ41Ee2NgnmUFkptBQ0GjyhpqdzCzPcLC4h7hF/xwxSrnimsRd1MIkKWt1peTsJ2eTarOzLlf8hOyFc4a83jZuIazByZoAl9TdvimGX0t6BfwfgIJgCE64fovTlFMTufIop2vO0tb8DCHe9GLRqRGiRfICHYF/pq1dokmSJW3KCfeddsDW3LoT0w==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Tue, 19 Nov 2024 13:38:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/11/2024 14:32, Luca Fancellu wrote:
>
>
> Hi Michal,
>
>> On 19 Nov 2024, at 11:51, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>>
>> At the moment, when printing memory ranges during early boot, endpoints
>> of some ranges are printed as inclusive (RAM, RESVD, SHMEM) and some
>> as exclusive (Initrd, MODULE). Make the behavior consistent and print
>> all the endpoints as inclusive.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>> ---
>
> Looks good to me!
>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>
> Outside early boot there are other places where we print exclusive ranges,
> do you know if there is any general style we should apply or does it depend on
> case by case?
Yes, there are other places where we print ranges with endpoints exclusive or
inclusive
but at least they are grouped together. Here it was quite confusing to find
lines next to
each other with different styles. I don't think there is any specific style we
should adhere to.
~Michal
|
